From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Linux ACPI <linux-acpi@vger.kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>
Subject: Re: [PATCH 0/2] ACPI: scan: Introduce a replacement for acpi_bus_get_device()
Date: Tue, 7 Dec 2021 13:30:20 +0200 [thread overview]
Message-ID: <Ya9FzEgjmMDvKEFr@lahna> (raw)
In-Reply-To: <2828957.e9J7NaK4W3@kreacher>
On Fri, Dec 03, 2021 at 05:34:58PM +0100, Rafael J. Wysocki wrote:
> Hi All,
>
> Because acpi_bus_get_device() turned out to be problematic in the past, it has
> been changed to the point that its calling convention doesn't make much sense
> any more (ie. the pointer passed to it as the second argument is cleared on
> errors and it can only return one error value if that pointer is nonzero, so
> there is some duplication of information in there) and it has to make redundant
> checks.
>
> Moreover, its name suggests some kind of reference counting which really isn't
> the case.
>
> Thus patch [1/2] introduces a replacement for it, called acpi_fetch_acpi_dev(),
> and makes the code in scan.c use it instead of acpi_bus_get_device() internally.
>
> Patch [2/2] updates all of the callers of acpi_bus_get_device() within the ACPI
> subsystem to use the replacement (which involves fixing a couple of bugs related
> to that).
Makes perfect sense!
For the series,
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
prev parent reply other threads:[~2021-12-07 11:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 16:34 [PATCH 0/2] ACPI: scan: Introduce a replacement for acpi_bus_get_device() Rafael J. Wysocki
2021-12-03 16:36 ` [PATCH 1/2] ACPI: scan: Introduce acpi_fetch_acpi_dev() Rafael J. Wysocki
2021-12-03 16:37 ` [PATCH 2/2] ACPI: Use acpi_fetch_acpi_dev() instead of acpi_bus_get_device() Rafael J. Wysocki
2021-12-06 9:04 ` [PATCH 0/2] ACPI: scan: Introduce a replacement for acpi_bus_get_device() Hans de Goede
2021-12-07 11:30 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya9FzEgjmMDvKEFr@lahna \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).