From: Vinod Koul <vkoul@kernel.org>
To: Georgi Djakov <djakov@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>,
Odelu Kukatla <okukatla@codeaurora.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] interconnect: qcom: Add SM8450 interconnect provider driver
Date: Tue, 7 Dec 2021 17:26:56 +0530 [thread overview]
Message-ID: <Ya9MCCYHIAjaW6GM@matsya> (raw)
In-Reply-To: <b4c43541-ffcd-d43c-3405-86d770905dd2@kernel.org>
On 01-12-21, 18:46, Georgi Djakov wrote:
> Hi Vinod,
>
> Thanks for working on this!
>
> On 1.12.21 9:25, Vinod Koul wrote:
> > Add driver for the Qualcomm interconnect buses found in SM8450 based
> > platforms. The topology consists of several NoCs that are controlled by
> > a remote processor that collects the aggregated bandwidth for each
> > master-slave pairs.
> >
> > This is based on the downstream driver by
> > Vivek Aknurwar <viveka@codeaurora.org>
>
> Maybe CC him too.
Will do
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > ---
> > drivers/interconnect/qcom/Kconfig | 9 +
> > drivers/interconnect/qcom/Makefile | 2 +
> > drivers/interconnect/qcom/sm8450.c | 1988 ++++++++++++++++++++++++++++
> > drivers/interconnect/qcom/sm8450.h | 169 +++
> > 4 files changed, 2168 insertions(+)
> > create mode 100644 drivers/interconnect/qcom/sm8450.c
> > create mode 100644 drivers/interconnect/qcom/sm8450.h
> >
> [..]
> > +static struct platform_driver qnoc_driver = {
> > + .probe = qnoc_probe,
> > + .remove = qnoc_remove,
> > + .driver = {
> > + .name = "qnoc-sm8450",
> > + .of_match_table = qnoc_of_match,
> > + .sync_state = icc_sync_state,
>
> We should set this callback only after we enable the client drivers to
> request bandwidth. Otherwise some path might get disabled because of no
> users. I would suggest to add sync_state after we describe the paths in
> DT.
Okay thanks for the suggestion. yeah we have only few paths described. I
will keep this as a separate patch and send few months down the line :)
--
~Vinod
prev parent reply other threads:[~2021-12-07 11:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 7:25 [PATCH 0/2] Add interconnect support for SM8450 Vinod Koul
2021-12-01 7:25 ` [PATCH 1/2] dt-bindings: interconnect: Add Qualcomm SM8450 DT bindings Vinod Koul
2021-12-01 16:45 ` Georgi Djakov
2021-12-07 11:55 ` Vinod Koul
2021-12-07 21:38 ` Rob Herring
2021-12-08 7:03 ` Vinod Koul
2021-12-01 7:25 ` [PATCH 2/2] interconnect: qcom: Add SM8450 interconnect provider driver Vinod Koul
2021-12-01 16:46 ` Georgi Djakov
2021-12-07 11:56 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya9MCCYHIAjaW6GM@matsya \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=okukatla@codeaurora.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).