From: Peter Zijlstra <peterz@infradead.org>
To: Maulik Shah <quic_mkshah@quicinc.com>
Cc: bjorn.andersson@linaro.org, rafael@kernel.org,
daniel.lezcano@linaro.org, linux-arm-msm@vger.kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
ulf.hansson@linaro.org, quic_lsrao@quicinc.com,
rnayak@codeaurora.org, Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH 2/4] sched/core: Export symbols used by cpuidle governors
Date: Fri, 26 Nov 2021 17:34:04 +0100 [thread overview]
Message-ID: <YaEMfIqBxv350Wjx@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <f7a1c6de-ae1d-1615-1212-bdb9bdcdbcbc@quicinc.com>
On Thu, Nov 25, 2021 at 07:01:44PM +0530, Maulik Shah wrote:
> Hi Peter,
>
> On 11/25/2021 3:05 PM, Peter Zijlstra wrote:
> > On Thu, Nov 25, 2021 at 02:24:39PM +0530, Maulik Shah wrote:
> > > Export symbols that are used by cpuidle menu governor in preparation
> > > to allow cpuidle governors to be compiled as modules.
> > >
> > > Cc: Ingo Molnar <mingo@redhat.com>
> > > Cc: Peter Zijlstra <peterz@infradead.org>
> > > Cc: Juri Lelli <juri.lelli@redhat.com>
> > > Cc: Vincent Guittot <vincent.guittot@linaro.org>
> > > Signed-off-by: Maulik Shah <quic_mkshah@quicinc.com>
> > > ---
> > > kernel/sched/core.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> > > index 8cffe31..1d031e0 100644
> > > --- a/kernel/sched/core.c
> > > +++ b/kernel/sched/core.c
> > > @@ -5047,6 +5047,7 @@ unsigned int nr_iowait_cpu(int cpu)
> > > {
> > > return atomic_read(&cpu_rq(cpu)->nr_iowait);
> > > }
> > > +EXPORT_SYMBOL(nr_iowait_cpu);
> > NACK, that function is batshit insane, exporting it serves nobody.
> Thanks for the review.
> Exporting is to serve cpuidle menu governor when its compiled as module
> (last patch in this series).
>
> otherwise we get below error during compilation,
> ERROR: modpost: "nr_iowait_cpu" [drivers/cpuidle/governors/menu.ko]
> undefined!
>
> Do you suggest to use something else instead of this?
Yeah, schedutil :-)
next prev parent reply other threads:[~2021-11-26 16:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 8:54 [PATCH 0/4] Allow cpuidle governors to be compiled as modules Maulik Shah
2021-11-25 8:54 ` [PATCH 1/4] tick/sched: Export symbols used by cpuidle governors Maulik Shah
2021-11-30 23:12 ` Thomas Gleixner
2021-11-25 8:54 ` [PATCH 2/4] sched/core: " Maulik Shah
2021-11-25 9:35 ` Peter Zijlstra
2021-11-25 13:31 ` Maulik Shah
2021-11-26 16:34 ` Peter Zijlstra [this message]
2021-11-25 8:54 ` [PATCH 3/4] cpuidle: governor: export cpuidle governor functions Maulik Shah
2021-11-25 8:54 ` [PATCH 4/4] cpuidle: governors: Allow the governors to be compiled as modules Maulik Shah
2021-11-25 12:27 ` [PATCH 0/4] Allow cpuidle " Rafael J. Wysocki
2021-11-25 13:18 ` Maulik Shah
2021-11-25 15:46 ` Rafael J. Wysocki
2021-11-25 17:16 ` Doug Smythies
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaEMfIqBxv350Wjx@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=juri.lelli@redhat.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=quic_lsrao@quicinc.com \
--cc=quic_mkshah@quicinc.com \
--cc=rafael@kernel.org \
--cc=rnayak@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).