From: Christoph Hellwig <hch@infradead.org>
To: Yu Kuai <yukuai3@huawei.com>
Cc: hch@infradead.org, tj@kernel.org, axboe@kernel.dk,
cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, yi.zhang@huawei.com
Subject: Re: [PATCH 2/4] blk-throtl: don't warn in tg_drain_bios()
Date: Mon, 29 Nov 2021 03:46:45 -0800 [thread overview]
Message-ID: <YaS9pfngMscOM3XA@infradead.org> (raw)
In-Reply-To: <20211127101059.477405-3-yukuai3@huawei.com>
On Sat, Nov 27, 2021 at 06:10:57PM +0800, Yu Kuai wrote:
> tg_drain_bios() will iterate until throtl_rb_first() return NULL,
> don't warn in such situation.
>
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
> ---
> block/blk-throttle.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/block/blk-throttle.c b/block/blk-throttle.c
> index 230e300c5856..25822c88bea1 100644
> --- a/block/blk-throttle.c
> +++ b/block/blk-throttle.c
> @@ -497,12 +497,13 @@ static void throtl_pd_free(struct blkg_policy_data *pd)
> }
>
> static struct throtl_grp *
> -throtl_rb_first(struct throtl_service_queue *parent_sq)
> +throtl_rb_first(struct throtl_service_queue *parent_sq, bool warn)
> {
> struct rb_node *n;
>
> n = rb_first_cached(&parent_sq->pending_tree);
> - WARN_ON_ONCE(!n);
> + if (warn)
> + WARN_ON_ONCE(!n);
> if (!n)
> return NULL;
Just shift then WARN_ON_ONCE into the callers that care.
next prev parent reply other threads:[~2021-11-29 13:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-27 10:10 [PATCH 0/4] cancel all throttled bios in del_gendisk() Yu Kuai
2021-11-27 10:10 ` [PATCH 1/4] Revert "blk-throttle: remove tg_drain_bios" Yu Kuai
2021-11-29 11:45 ` Christoph Hellwig
2021-11-27 10:10 ` [PATCH 2/4] blk-throtl: don't warn in tg_drain_bios() Yu Kuai
2021-11-29 11:46 ` Christoph Hellwig [this message]
2021-11-27 10:10 ` [PATCH 3/4] blk-throtl: introduce blk_throtl_cancel_bios() Yu Kuai
2021-11-29 11:47 ` Christoph Hellwig
2021-11-29 13:58 ` yukuai (C)
2021-11-27 10:10 ` [PATCH 4/4] block: cancel all throttled bios in del_gendisk() Yu Kuai
-- strict thread matches above, loose matches on Subject: below --
2021-09-22 12:51 [PATCH 0/4] cancel all throttled bios in blk_cleanup_queue() Yu Kuai
2021-09-22 12:51 ` [PATCH 2/4] blk-throtl: don't warn in tg_drain_bios() Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaS9pfngMscOM3XA@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).