From: Rob Herring <robh@kernel.org>
To: Aswath Govindraju <a-govindraju@ti.com>
Cc: Rob Herring <robh+dt@kernel.org>, Nishanth Menon <nm@ti.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
linux-kernel@vger.kernel.org,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Tero Kristo <kristo@kernel.org>
Subject: Re: [PATCH 2/5] dt-bindings: pinctrl: k3: Introduce pinmux definitions for J721S2
Date: Mon, 29 Nov 2021 18:11:39 -0600 [thread overview]
Message-ID: <YaVsO9qbX5J8uuEn@robh.at.kernel.org> (raw)
In-Reply-To: <20211119133052.17793-3-a-govindraju@ti.com>
On Fri, 19 Nov 2021 19:00:47 +0530, Aswath Govindraju wrote:
> Add pinctrl macros for J721S2 SoC. These macro definitions are
> similar to that of J721E, but adding new definitions to avoid
> any naming confusions in the soc dts files.
>
> checkpatch insists the following error exists:
> ERROR: Macros with complex values should be enclosed in parentheses
>
> However, we do not need parentheses enclosing the values for this
> macro as we do intend it to generate two separate values as has been
> done for other similar platforms.
>
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> ---
> include/dt-bindings/pinctrl/k3.h | 3 +++
> 1 file changed, 3 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2021-11-30 0:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 13:30 [PATCH 0/5] J721S2: Add initial support Aswath Govindraju
2021-11-19 13:30 ` [PATCH 1/5] dt-bindings: arm: ti: Add bindings for J721s2 SoC Aswath Govindraju
2021-11-30 0:10 ` Rob Herring
2021-11-19 13:30 ` [PATCH 2/5] dt-bindings: pinctrl: k3: Introduce pinmux definitions for J721S2 Aswath Govindraju
2021-11-30 0:11 ` Rob Herring [this message]
2021-11-19 13:30 ` [PATCH 3/5] arm64: dts: ti: Add initial support for J721S2 SoC Aswath Govindraju
2021-12-03 7:13 ` Kishon Vijay Abraham I
2021-11-19 13:30 ` [PATCH 4/5] arm64: dts: ti: Add initial support for J721S2 System on Module Aswath Govindraju
2021-11-19 13:30 ` [PATCH 5/5] arch: arm64: ti: Add support J721S2 Common Processor Board Aswath Govindraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaVsO9qbX5J8uuEn@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=a-govindraju@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).