From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61D3BC433EF for ; Tue, 30 Nov 2021 06:44:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238725AbhK3GrV (ORCPT ); Tue, 30 Nov 2021 01:47:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233099AbhK3GrT (ORCPT ); Tue, 30 Nov 2021 01:47:19 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B013C061574; Mon, 29 Nov 2021 22:44:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ddVaDeU0Jvjl+Fe4JdR7EXlePtBzgo3q/f4WhbMSGg8=; b=zvinEgKsMo0VOvoNk6EqMfOTHA is82Ygjn7cQ+TV0DGLvAG6poLX6o+vpcCAYRCTLd88ob7yBNd5nqgWWxlpxCkIrsyFQ+6AmYq9EW/ d0QgibAE31oSrDEWHigEeapOMOBq4LBXpJlHIxQoVWyVf8wuvLa5kfh64D2H/VoDuGk6YGydf2/lr l7T+8eMDaNU2lWYjmFDA7RCRe41Uikv8r2FMh6WNsZpYMPCeLrJY5AUecVjRLlYBRp3x15S6XwUXJ FQWZ85WTS/KJX22zZnBVlxpUlhFuNBh6I69Fz5zquYhAT0xjYOe00vvqHR9vE+PkyIA3ZHr8g8igp RdvGHtOg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrwrv-003pfI-8E; Tue, 30 Nov 2021 06:43:59 +0000 Date: Mon, 29 Nov 2021 22:43:59 -0800 From: Christoph Hellwig To: Yu Kuai Cc: hch@infradead.org, tj@kernel.org, axboe@kernel.dk, cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com Subject: Re: [PATCH v2 2/2] block: cancel all throttled bios in del_gendisk() Message-ID: References: <20211130011730.2584339-1-yukuai3@huawei.com> <20211130011730.2584339-3-yukuai3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211130011730.2584339-3-yukuai3@huawei.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This look fine to me, but I think someone who actually knows the throttle code also needs to look over it.