From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kbuild@lists.01.org, lianzhi chang <changlianzhi@uniontech.com>,
linux-kernel@vger.kernel.org, lkp@intel.com,
kbuild-all@lists.01.org, dmitry.torokhov@gmail.com,
gregkh@linuxfoundation.org, jirislaby@kernel.org,
282827961@qq.com
Subject: Re: [PATCH v18] tty: Fix the keyboard led light display problem
Date: Tue, 30 Nov 2021 10:49:41 +0200 [thread overview]
Message-ID: <YaXlpQdOHT2LEpPR@smile.fi.intel.com> (raw)
In-Reply-To: <202111291912.gGbp6mtv-lkp@intel.com>
On Tue, Nov 30, 2021 at 10:53:37AM +0300, Dan Carpenter wrote:
> Hi lianzhi,
>
> url: https://github.com/0day-ci/linux/commits/lianzhi-chang/tty-Fix-the-keyboard-led-light-display-problem/20211129-120853
> base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
> config: i386-randconfig-m021-20211128 (https://download.01.org/0day-ci/archive/20211129/202111291912.gGbp6mtv-lkp@intel.com/config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> New smatch warnings:
> drivers/tty/vt/keyboard.c:425 vt_set_leds_compute_shiftstate() warn: was && intended here instead of ||?
Indeed, how this had been tested?
> 560757cc1f5e54 drivers/tty/vt/keyboard.c lianzhi chang 2021-11-29 @425 if (kb->kbdmode != VC_RAW ||
> 560757cc1f5e54 drivers/tty/vt/keyboard.c lianzhi chang 2021-11-29 426 kb->kbdmode != VC_MEDIUMRAW ||
> 560757cc1f5e54 drivers/tty/vt/keyboard.c lianzhi chang 2021-11-29 427 kb->kbdmode != VC_OFF) {
>
> && was intended instead of ||.
>
> 560757cc1f5e54 drivers/tty/vt/keyboard.c lianzhi chang 2021-11-29 428 vt_switch = true;
> 63f24a7fafd448 drivers/tty/vt/keyboard.c Jiri Slaby 2021-01-05 429 set_leds();
> 560757cc1f5e54 drivers/tty/vt/keyboard.c lianzhi chang 2021-11-29 430 }
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-11-30 8:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 4:04 [PATCH v18] tty: Fix the keyboard led light display problem lianzhi chang
2021-11-29 7:16 ` Dmitry Torokhov
2021-11-29 11:35 ` Andy Shevchenko
2021-11-30 7:53 ` Dan Carpenter
2021-11-30 8:49 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaXlpQdOHT2LEpPR@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=282827961@qq.com \
--cc=changlianzhi@uniontech.com \
--cc=dan.carpenter@oracle.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).