From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AA99C433EF for ; Tue, 30 Nov 2021 15:15:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243865AbhK3PRL (ORCPT ); Tue, 30 Nov 2021 10:17:11 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:59664 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242890AbhK3PIH (ORCPT ); Tue, 30 Nov 2021 10:08:07 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 691D7B81A24; Tue, 30 Nov 2021 15:04:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4B12C53FC1; Tue, 30 Nov 2021 15:04:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638284684; bh=Alrkq2tkKKKGG2UExFARuPj7sJr48gbzjpZP81Br49U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ffrK8N4jIIT0Z+rrBunGxwfgMjwYMw9MBA2p0u/8x1d+4i4Ol+FTed1CxMtQ1+O1f 06/up2+crEZrvHmtuVvtJWIWesOPMH3HcuFYL6andIpGYnCAQ1pDnoHm4ggeKGzFUD 9uNX4xgQlGHn2tRoJDrEn8iBTAEprXqxXM+jxiXfnp2qOGF2vZUjwKOAWjHpzxnmDX IdUwM8YOpR9n0kMkQN8SLBkqlI4W1OfBCGcnptOmIJKpu0kb23bKZZpa+zJX624SX7 Behsay8yPdIISUkXFqqtBVsu290eoCuxWoQ0/lVivsaabKPiJvZ0sFsGbNTB0oe6GP gXf6lTnyBEMTQ== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 011BB40002; Tue, 30 Nov 2021 12:04:41 -0300 (-03) Date: Tue, 30 Nov 2021 12:04:41 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Andi Kleen , Jiri Olsa , Namhyung Kim , John Garry , Kajol Jain , "Paul A . Clarke" , Riccardo Mancini , Kan Liang , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Vineet Singh , eranian@google.com Subject: Re: [PATCH v2 1/2] perf evlist: Allow setting arbitrary leader Message-ID: References: <20211118220647.2355999-1-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211118220647.2355999-1-irogers@google.com> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Nov 18, 2021 at 02:06:46PM -0800, Ian Rogers escreveu: > The leader of a group is the first, but allow it to be an arbitrary > list member so that for Intel topdown events slots may always be the > group leader. > > Reviewed-by: Kajol Jain > Signed-off-by: Ian Rogers > --- > tools/lib/perf/evlist.c | 15 +++++++++------ > tools/lib/perf/include/internal/evlist.h | 2 +- > tools/perf/util/parse-events.c | 2 +- > 3 files changed, 11 insertions(+), 8 deletions(-) > > diff --git a/tools/lib/perf/evlist.c b/tools/lib/perf/evlist.c > index e37dfad31383..974da341b8b0 100644 > --- a/tools/lib/perf/evlist.c > +++ b/tools/lib/perf/evlist.c > @@ -643,14 +643,14 @@ perf_evlist__next_mmap(struct perf_evlist *evlist, struct perf_mmap *map, > return overwrite ? evlist->mmap_ovw_first : evlist->mmap_first; > } > > -void __perf_evlist__set_leader(struct list_head *list) > +void __perf_evlist__set_leader(struct list_head *list, struct perf_evsel *leader) > { > - struct perf_evsel *evsel, *leader; > + struct perf_evsel *first, *last, *evsel; > > - leader = list_entry(list->next, struct perf_evsel, node); > - evsel = list_entry(list->prev, struct perf_evsel, node); > + first = list_entry(list->next, struct perf_evsel, node); > + last = list_entry(list->prev, struct perf_evsel, node); We have list_first_entry() and list_last_entry(): For instance: tools/perf/util/parse-events.c: leader = list_first_entry(list, struct evsel, core.node); Can we use it here? > - leader->nr_members = evsel->idx - leader->idx + 1; > + leader->nr_members = last->idx - first->idx + 1; > > __perf_evlist__for_each_entry(list, evsel) > evsel->leader = leader; > @@ -659,7 +659,10 @@ void __perf_evlist__set_leader(struct list_head *list) > void perf_evlist__set_leader(struct perf_evlist *evlist) > { > if (evlist->nr_entries) { > + struct perf_evsel *first = list_entry(evlist->entries.next, > + struct perf_evsel, node); > + > evlist->nr_groups = evlist->nr_entries > 1 ? 1 : 0; > - __perf_evlist__set_leader(&evlist->entries); > + __perf_evlist__set_leader(&evlist->entries, first); > } > } > diff --git a/tools/lib/perf/include/internal/evlist.h b/tools/lib/perf/include/internal/evlist.h > index f366dbad6a88..6f74269a3ad4 100644 > --- a/tools/lib/perf/include/internal/evlist.h > +++ b/tools/lib/perf/include/internal/evlist.h > @@ -127,5 +127,5 @@ int perf_evlist__id_add_fd(struct perf_evlist *evlist, > > void perf_evlist__reset_id_hash(struct perf_evlist *evlist); > > -void __perf_evlist__set_leader(struct list_head *list); > +void __perf_evlist__set_leader(struct list_head *list, struct perf_evsel *leader); > #endif /* __LIBPERF_INTERNAL_EVLIST_H */ > diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c > index 5bfb6f892489..6308ba739d19 100644 > --- a/tools/perf/util/parse-events.c > +++ b/tools/perf/util/parse-events.c > @@ -1834,8 +1834,8 @@ void parse_events__set_leader(char *name, struct list_head *list, > if (parse_events__set_leader_for_uncore_aliase(name, list, parse_state)) > return; > > - __perf_evlist__set_leader(list); > leader = list_entry(list->next, struct evsel, core.node); > + __perf_evlist__set_leader(list, &leader->core); > leader->group_name = name ? strdup(name) : NULL; Ditto > } > > -- > 2.34.0.rc2.393.gf8c9666880-goog -- - Arnaldo