From: Luis Chamberlain <mcgrof@kernel.org>
To: Alexey Avramov <hakavlad@inbox.lv>
Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
corbet@lwn.net, akpm@linux-foundation.org, keescook@chromium.org,
yzaikin@google.com, oleksandr@natalenko.name, kernel@xanmod.org,
aros@gmx.com, iam@valdikss.org.ru, hakavlad@gmail.com
Subject: Re: [PATCH] mm/vmscan: add sysctl knobs for protecting the working set
Date: Tue, 30 Nov 2021 07:28:40 -0800 [thread overview]
Message-ID: <YaZDKLzWBLdcnok7@bombadil.infradead.org> (raw)
In-Reply-To: <20211130201652.2218636d@mail.inbox.lv>
On Tue, Nov 30, 2021 at 08:16:52PM +0900, Alexey Avramov wrote:
> diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> index 083be6af2..65fc38756 100644
> --- a/kernel/sysctl.c
> +++ b/kernel/sysctl.c
> @@ -3132,6 +3132,27 @@ static struct ctl_table vm_table[] = {
> },
> #endif
> {
> + .procname = "anon_min_kbytes",
> + .data = &sysctl_anon_min_kbytes,
> + .maxlen = sizeof(unsigned long),
> + .mode = 0644,
> + .proc_handler = proc_doulongvec_minmax,
> + },
> + {
> + .procname = "clean_low_kbytes",
> + .data = &sysctl_clean_low_kbytes,
> + .maxlen = sizeof(unsigned long),
> + .mode = 0644,
> + .proc_handler = proc_doulongvec_minmax,
> + },
> + {
> + .procname = "clean_min_kbytes",
> + .data = &sysctl_clean_min_kbytes,
> + .maxlen = sizeof(unsigned long),
> + .mode = 0644,
> + .proc_handler = proc_doulongvec_minmax,
> + },
> + {
> .procname = "user_reserve_kbytes",
> .data = &sysctl_user_reserve_kbytes,
> .maxlen = sizeof(sysctl_user_reserve_kbytes),
Please don't clutter this file anymore than what we have with random
sysctls, as otherwise it becomes a pain to deal with merge conficts.
You can use register_sysctl_init("vm", whatever_your_local_table_name)
within the file you are adding your sysctl.
Luis
next prev parent reply other threads:[~2021-11-30 15:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 11:16 [PATCH] mm/vmscan: add sysctl knobs for protecting the working set Alexey Avramov
2021-11-30 15:28 ` Luis Chamberlain [this message]
2021-11-30 18:56 ` Oleksandr Natalenko
2021-12-01 15:51 ` Alexey Avramov
2021-12-02 18:05 ` ValdikSS
2021-12-02 21:58 ` Andrew Morton
2021-12-03 11:59 ` Vlastimil Babka
2021-12-03 13:27 ` Alexey Avramov
2021-12-06 9:59 ` Michal Hocko
2022-01-09 22:59 ` Barry Song
2021-12-03 14:01 ` Oleksandr Natalenko
2021-12-12 20:15 ` Alexey Avramov
2021-12-13 9:06 ` Barry Song
2021-12-13 9:07 ` Michal Hocko
2021-12-13 8:38 ` Barry Song
2022-01-25 8:19 ` ValdikSS
2022-02-12 0:01 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaZDKLzWBLdcnok7@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=aros@gmx.com \
--cc=corbet@lwn.net \
--cc=hakavlad@gmail.com \
--cc=hakavlad@inbox.lv \
--cc=iam@valdikss.org.ru \
--cc=keescook@chromium.org \
--cc=kernel@xanmod.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=oleksandr@natalenko.name \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).