From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Kent Gibson <warthog618@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Shuah Khan <shuah@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v11 2/6] gpiolib: allow to specify the firmware node in struct gpio_chip
Date: Wed, 1 Dec 2021 16:54:56 +0200 [thread overview]
Message-ID: <YaeMwP3XocWjrZBv@smile.fi.intel.com> (raw)
In-Reply-To: <CAMRc=McuGvUUPt9VMARqdNttbXyau5ib-MgR_EYskxqJtUxcsQ@mail.gmail.com>
On Wed, Dec 01, 2021 at 03:36:29PM +0100, Bartosz Golaszewski wrote:
> On Wed, Dec 1, 2021 at 3:34 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Wed, Dec 01, 2021 at 04:28:19PM +0200, Andy Shevchenko wrote:
> > > On Wed, Dec 01, 2021 at 02:53:42PM +0100, Bartosz Golaszewski wrote:
> > > > On Wed, Dec 1, 2021 at 2:40 PM Andy Shevchenko
> > > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > > On Wed, Dec 01, 2021 at 02:11:28PM +0100, Bartosz Golaszewski wrote:
> > > > > > On Tue, Nov 30, 2021 at 10:04 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > > > Drop this patch and drop the line where the fwnode is assigned in
> > > > gpio-sim.c. Then probe the device and print the addresses of the
> > > > parent and child swnodes. See how they are the same and don't match
> > > > the swnode hierarchy we created. You can then apply this patch and see
> > > > how it becomes correct.
> > >
> > > Thanks. I will give a spin.
> > >
> > > Note, it seems I have to revert your older code first...
> >
> > Okay, I have to postpone because simple revert doesn't work for me.
> > Can you clean up the next, please and I can use it starting from tomorrow?
> >
> >
> > $ git tag --contains 5065e08e4ef3
> > DONT-USE-next-20211105
> > next-20211101
> > next-20211102
> > next-20211103
> > next-20211104
> > next-20211105
> > next-20211106
> > next-20211108
> > next-20211109
> > next-20211110
> > next-20211111
> > next-20211112
> > next-20211115
> > next-20211116
> > next-20211117
> > next-20211118
> > next-20211123
> > next-20211124
> > next-20211125
> > next-20211126
> > next-20211129
> > next-20211130
> > next-20211201
> None of this is in next, please use:
> https://github.com/brgl/linux/tree/topic/gpio-sim-v12 if you want a
> branch.
It the old version that prevents me to apply (my branches based on next).
> I just thought you were going to simply apply these patches.
That's correct, but see above.
Anyway, I'm already switched tasks for today. Maybe I will have some time
later on.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-12-01 14:56 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 15:41 [PATCH v11 0/6] gpio-sim: configfs-based GPIO simulator Bartosz Golaszewski
2021-11-30 15:41 ` [PATCH v11 1/6] gpiolib: provide gpiod_remove_hogs() Bartosz Golaszewski
2021-11-30 15:41 ` [PATCH v11 2/6] gpiolib: allow to specify the firmware node in struct gpio_chip Bartosz Golaszewski
2021-11-30 16:14 ` Andy Shevchenko
2021-11-30 16:19 ` Andy Shevchenko
2021-11-30 16:55 ` Andy Shevchenko
2021-11-30 18:32 ` Bartosz Golaszewski
2021-11-30 20:31 ` Andy Shevchenko
2021-11-30 20:25 ` Bartosz Golaszewski
2021-11-30 20:59 ` Andy Shevchenko
2021-11-30 21:04 ` Bartosz Golaszewski
2021-12-01 13:11 ` Bartosz Golaszewski
2021-12-01 13:39 ` Andy Shevchenko
2021-12-01 13:53 ` Bartosz Golaszewski
2021-12-01 14:28 ` Andy Shevchenko
2021-12-01 14:33 ` Andy Shevchenko
2021-12-01 14:36 ` Bartosz Golaszewski
2021-12-01 14:54 ` Andy Shevchenko [this message]
2021-12-02 10:57 ` Andy Shevchenko
2021-12-02 11:24 ` Bartosz Golaszewski
2021-12-02 11:35 ` Andy Shevchenko
2021-12-02 11:37 ` Andy Shevchenko
2021-12-02 13:06 ` Bartosz Golaszewski
2021-12-02 13:44 ` Andy Shevchenko
2021-12-02 13:52 ` Bartosz Golaszewski
2021-12-02 15:40 ` Andy Shevchenko
2021-12-02 17:00 ` Bartosz Golaszewski
2021-12-02 17:29 ` Andy Shevchenko
2021-11-30 15:41 ` [PATCH v11 3/6] gpio: sim: new testing module Bartosz Golaszewski
2021-11-30 15:41 ` [PATCH v11 4/6] selftests: gpio: provide a helper for reading chip info Bartosz Golaszewski
2021-11-30 15:41 ` [PATCH v11 5/6] selftests: gpio: add a helper for reading GPIO line names Bartosz Golaszewski
2021-11-30 15:41 ` [PATCH v11 6/6] selftests: gpio: add test cases for gpio-sim Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaeMwP3XocWjrZBv@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=geert@linux-m68k.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).