From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1818C433EF for ; Wed, 1 Dec 2021 15:32:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351002AbhLAPfW (ORCPT ); Wed, 1 Dec 2021 10:35:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350252AbhLAPfU (ORCPT ); Wed, 1 Dec 2021 10:35:20 -0500 Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EA2AC061748 for ; Wed, 1 Dec 2021 07:31:59 -0800 (PST) Received: by mail-oi1-x22d.google.com with SMTP id s139so49192646oie.13 for ; Wed, 01 Dec 2021 07:31:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=uFMUhbGSve6XOXG4hT9U3q9GImUbsSFy9Vah1OZisDI=; b=VEqQ4qm73WYGNDTAMVaJv66zUxxEcw1I76eSBm6a3yxe4VglM1A8bd3AWGyIbSITsG L15cql+Aqb1LKY7WuUgdhnqVjOUvVvUYgw+iOUVzlqdv6g9JpLdLgFZJrdGc/qfem8Ic SmD6x7TfGe+WVqdeR9eLomzxti3j9u6g8H2Q+TruWVTvhxgGH/EbFn2BmHIKE77dcYPQ AVdAk4ha5MiNJ/fABaqxzubfxrrIAJ9KPPFfBnbxEAcMPPf7nSif221xhhqJDC0ethkY AdCVXauvs3kwFIM18EZC0A7yrJt/3j+OBqkcd047bVeqxiwyuaUmU+7dmprGUqcue6tA Pcfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uFMUhbGSve6XOXG4hT9U3q9GImUbsSFy9Vah1OZisDI=; b=itvj56jnnCokIle7pCvzgLLYSkJLM44eI86OstjMA3vSHjkGXgswLhanuJOU3cHjAd U0ZgMgV+eiARrwyddb/Ufoy7QPxp3AUZS6jb6++u43348dj5wztgi0/IiT4kNSNy+wfO gt5nBctbntG+PUQYtLWvrtgovHLW7HIQ+PfdUyLLd/uV115bLvFOmj8gpsoY47yFFuAV TDHJ9JwsZEMIX8jidz9dKRN//RdqW+HEL1J7iZJYSqMgiI16XxhU21gJidTgZHBTGiXG ERaQ9xFrIpUQ1//7en7CNQ5FG81TMXfoc9IugclgxthapZWiaM0uOkFYmdLTE58l/J/S CDwQ== X-Gm-Message-State: AOAM5337EGHfF8LI4yPWBd3pEGmPVswZWGvPaey8FZ14hgdPk8tNRxGi PfbHqM6JI+CSeb5SiYdoOtycug== X-Google-Smtp-Source: ABdhPJwnqbKqj2jV7StOM44pZVUXOOt1pFckEfKefaxTyLXR8Nzec8O4l7stJ4JSVQj5U2bon04vgw== X-Received: by 2002:aca:1204:: with SMTP id 4mr6800261ois.136.1638372718608; Wed, 01 Dec 2021 07:31:58 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id m2sm7954oop.12.2021.12.01.07.31.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Dec 2021 07:31:58 -0800 (PST) Date: Wed, 1 Dec 2021 09:31:53 -0600 From: Bjorn Andersson To: Sankeerth Billakanti Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, agross@kernel.org, robh+dt@kernel.org, robdclark@gmail.com, seanpaul@chromium.org, swboyd@chromium.org, quic_kalyant@quicinc.com, quic_abhinavk@quicinc.com, dianders@chromium.org, quic_khsieh@quicinc.com, quic_mkrishn@quicinc.com Subject: Re: [PATCH v4 3/4] arm64: dts: qcom: sc7280: add edp display dt nodes Message-ID: References: <1637580369-876-1-git-send-email-quic_sbillaka@quicinc.com> <1637580369-876-3-git-send-email-quic_sbillaka@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1637580369-876-3-git-send-email-quic_sbillaka@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 22 Nov 05:26 CST 2021, Sankeerth Billakanti wrote: > Add edp controller and phy DT nodes for sc7280. > > Signed-off-by: Krishna Manikandan If Krishna authored the patch (he certified its origin first), then he should be From: as well. > Reviewed-by: Stephen Boyd > Signed-off-by: Sankeerth Billakanti > --- > > Changes in v4: > None > > Changes in v3: > - Add one clock cell per line (Stephen Boyd) > - Unit address should match first reg property (Stephen Boyd) > - Remove new line (Stephen Boyd) > - Add the dsi_phy clocks in dispcc (Kuogee Hsieh) > > Changes in v2: > - Move regulator definitions to board file (Matthias Kaehlcke) > - Move the gpio definitions to board file (Matthias Kaehlcke) > - Move the pinconf to board file (Matthias Kaehlcke) > - Move status property (Stephen Boyd) > - Drop flags from interrupts (Stephen Boyd) > - Add clock names one per line for readability (Stephen Boyd) > - Rename edp-opp-table (Stephen Boyd) > > arch/arm64/boot/dts/qcom/sc7280.dtsi | 107 ++++++++++++++++++++++++++++++++++- > 1 file changed, 105 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index 12c4d32..5ad500e 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -2695,8 +2695,8 @@ > <&dsi_phy 1>, > <0>, > <0>, > - <0>, > - <0>; > + <&edp_phy 0>, > + <&edp_phy 1>; > clock-names = "bi_tcxo", > "gcc_disp_gpll0_clk", > "dsi0_phy_pll_out_byteclk", > @@ -2784,6 +2784,13 @@ > remote-endpoint = <&dsi0_in>; > }; > }; > + > + port@1 { > + reg = <1>; > + dpu_intf5_out: endpoint { > + remote-endpoint = <&edp_in>; > + }; > + }; > }; > > mdp_opp_table: opp-table { > @@ -2899,6 +2906,102 @@ > > status = "disabled"; > }; > + > + msm_edp: edp@aea0000 { mdss_edp: > + compatible = "qcom,sc7280-edp"; > + > + reg = <0 0xaea0000 0 0x200>, > + <0 0xaea0200 0 0x200>, > + <0 0xaea0400 0 0xc00>, > + <0 0xaea1000 0 0x400>; > + > + interrupt-parent = <&mdss>; > + interrupts = <14>; > + > + clocks = <&rpmhcc RPMH_CXO_CLK>, > + <&gcc GCC_EDP_CLKREF_EN>, > + <&dispcc DISP_CC_MDSS_AHB_CLK>, > + <&dispcc DISP_CC_MDSS_EDP_AUX_CLK>, > + <&dispcc DISP_CC_MDSS_EDP_LINK_CLK>, > + <&dispcc DISP_CC_MDSS_EDP_LINK_INTF_CLK>, > + <&dispcc DISP_CC_MDSS_EDP_PIXEL_CLK>; > + clock-names = "core_xo", > + "core_ref", > + "core_iface", > + "core_aux", > + "ctrl_link", > + "ctrl_link_iface", > + "stream_pixel"; > + #clock-cells = <1>; > + assigned-clocks = <&dispcc DISP_CC_MDSS_EDP_LINK_CLK_SRC>, > + <&dispcc DISP_CC_MDSS_EDP_PIXEL_CLK_SRC>; > + assigned-clock-parents = <&edp_phy 0>, <&edp_phy 1>; > + > + phys = <&edp_phy>; > + phy-names = "dp"; > + > + operating-points-v2 = <&edp_opp_table>; > + power-domains = <&rpmhpd SC7280_CX>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@0 { > + reg = <0>; > + edp_in: endpoint { > + remote-endpoint = <&dpu_intf5_out>; > + }; > + }; > + }; > + > + edp_opp_table: opp-table { > + compatible = "operating-points-v2"; > + > + opp-160000000 { > + opp-hz = /bits/ 64 <160000000>; > + required-opps = <&rpmhpd_opp_low_svs>; > + }; > + > + opp-270000000 { > + opp-hz = /bits/ 64 <270000000>; > + required-opps = <&rpmhpd_opp_svs>; > + }; > + > + opp-540000000 { > + opp-hz = /bits/ 64 <540000000>; > + required-opps = <&rpmhpd_opp_nom>; > + }; > + > + opp-810000000 { > + opp-hz = /bits/ 64 <810000000>; > + required-opps = <&rpmhpd_opp_nom>; > + }; > + }; > + }; > + > + edp_phy: phy@aec2a00 { mdss_edp_phy Thanks, Bjorn > + compatible = "qcom,sc7280-edp-phy"; > + > + reg = <0 0xaec2a00 0 0x19c>, > + <0 0xaec2200 0 0xa0>, > + <0 0xaec2600 0 0xa0>, > + <0 0xaec2000 0 0x1c0>; > + > + clocks = <&rpmhcc RPMH_CXO_CLK>, > + <&gcc GCC_EDP_CLKREF_EN>; > + clock-names = "aux", > + "cfg_ahb"; > + > + #clock-cells = <1>; > + #phy-cells = <0>; > + > + status = "disabled"; > + }; > }; > > pdc: interrupt-controller@b220000 { > -- > 2.7.4 >