From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C03B6C433EF for ; Thu, 2 Dec 2021 02:13:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353330AbhLBCQx (ORCPT ); Wed, 1 Dec 2021 21:16:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238759AbhLBCQu (ORCPT ); Wed, 1 Dec 2021 21:16:50 -0500 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E143CC06174A for ; Wed, 1 Dec 2021 18:13:28 -0800 (PST) Received: by mail-pl1-x633.google.com with SMTP id m24so19132362pls.10 for ; Wed, 01 Dec 2021 18:13:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xqdq69bklkVGPaiuC/hhcniUDsb69a5Tsomp+eMdT8Y=; b=kLe2Jr2E6gqbImzVXFbWuWelxOvMTjUr3eE3r6UXGeXlSFHQJujz3lKGG1L8GrT/jA tZc+qlJVZ58JjH0g5XNMGk6jNl01J+5YdmbMgSs4RYG+rZnunYfoVS5CVwrghZldDJyO QsL/vfDrNDDfrswvVpKh4G3/Rp546pliFVtuK/l3YPREcTeI5wXswL8GsLhOo8t+L3zO eEWvcu/xAKtGB5MCBINyHO9v189tvqdZBzA343XYcBSiMvbmvZ5h5HhvMN1neTO3sFuf 4KjN5JhpI1gvBnhZ1ekaA2hzk6QsMmK5uzhPhUAXOQETZO338FaIlVCWBJjU9Mdq9WON fmYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xqdq69bklkVGPaiuC/hhcniUDsb69a5Tsomp+eMdT8Y=; b=DM5zrVkcxz1fFzsALnXvt9n/cm3tFJbOGti/cb0jUVtwgprmG+/JdoLobGPKfy4XaH yLATGpieVbniNj4O4BCVgAmK0uo4pGeqndD20WBSQIS4+d1VSyAqUOv2jij4YvGYo4fk sjc642027jEY537oQKqiooCwN30J0qtGfugEkTxeAIBEyja1hp+1StSmP18eoT4tfvu7 8WJaOUNDpR4JxFWrv6pRAAhiHRRBYhnnaFc+vHY90OCAKLP42eA4RTE4ZK14H7p0bZlD 2kyBDd3Cd9b4VZQr/VTJYlpNDQ4OomMXw2UteUVtSgQXbKMv1/FYpnbc1hwuDACPWJST f3Kw== X-Gm-Message-State: AOAM533dwWgq1hXB+IUYP7zpC4/5ki0ZPgjvLdn7xmcQ6avb28V2hBrw CL5ATEJCD1P8I/KzHJ9Qd/Gvag== X-Google-Smtp-Source: ABdhPJwI9/kW+841BCq3bJVjpyet3MmhhrawiCLnHAmmZ9PuYqso3ZTZlCgmtcoT/lCxdVVnUZYA0g== X-Received: by 2002:a17:90b:92:: with SMTP id bb18mr2454366pjb.133.1638411208204; Wed, 01 Dec 2021 18:13:28 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id j7sm1152501pfc.74.2021.12.01.18.13.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Dec 2021 18:13:27 -0800 (PST) Date: Thu, 2 Dec 2021 02:13:24 +0000 From: Sean Christopherson To: Vitaly Kuznetsov Cc: Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Ajay Garg , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Arnd Bergmann Subject: Re: [PATCH v2 8/8] KVM: x86: Add checks for reserved-to-zero Hyper-V hypercall fields Message-ID: References: <20211030000800.3065132-1-seanjc@google.com> <20211030000800.3065132-9-seanjc@google.com> <87v91cjhch.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87v91cjhch.fsf@vitty.brq.redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 01, 2021, Vitaly Kuznetsov wrote: > Sean Christopherson writes: > > > Add checks for the three fields in Hyper-V's hypercall params that must > > be zero. Per the TLFS, HV_STATUS_INVALID_HYPERCALL_INPUT is returned if > > "A reserved bit in the specified hypercall input value is non-zero." > > > > Note, the TLFS has an off-by-one bug for the last reserved field, which > > it defines as being bits 64:60. The same section states "The input field > > 64-bit value called a hypercall input value.", i.e. bit 64 doesn't > > exist. > > This version are you looking at? I can't see this issue in 6.0b It's the web-based documentation, the 6.0b PDF indeed does not have the same bug. https://docs.microsoft.com/en-us/virtualization/hyper-v-on-windows/tlfs/hypercall-interface#hypercall-inputs