From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1209BC433F5 for ; Thu, 2 Dec 2021 09:38:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356503AbhLBJli (ORCPT ); Thu, 2 Dec 2021 04:41:38 -0500 Received: from mga06.intel.com ([134.134.136.31]:25482 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345914AbhLBJlg (ORCPT ); Thu, 2 Dec 2021 04:41:36 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10185"; a="297469623" X-IronPort-AV: E=Sophos;i="5.87,281,1631602800"; d="scan'208";a="297469623" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2021 01:38:14 -0800 X-IronPort-AV: E=Sophos;i="5.87,281,1631602800"; d="scan'208";a="609920216" Received: from smile.fi.intel.com ([10.237.72.184]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2021 01:38:10 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1msiWZ-001LKK-It; Thu, 02 Dec 2021 11:37:07 +0200 Date: Thu, 2 Dec 2021 11:37:07 +0200 From: Andy Shevchenko To: Anand Ashok Dumbre Cc: "linux-kernel@vger.kernel.org" , "jic23@kernel.org" , "lars@metafoo.de" , "linux-iio@vger.kernel.org" , git , Michal Simek , "gregkh@linuxfoundation.org" , "rafael@kernel.org" , "linux-acpi@vger.kernel.org" , "heikki.krogerus@linux.intel.com" Subject: Re: [PATCH v11 1/5] device property: Add fwnode_iomap() Message-ID: References: <20211124225407.17793-1-anand.ashok.dumbre@xilinx.com> <20211124225407.17793-2-anand.ashok.dumbre@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 02, 2021 at 09:10:02AM +0000, Anand Ashok Dumbre wrote: > > From: Anand Ashok Dumbre > > Sent: Tuesday 30 November 2021 9:58 PM > > > From: Andy Shevchenko > > > Sent: Thursday 25 November 2021 11:42 AM > > > On Wed, Nov 24, 2021 at 10:54:03PM +0000, Anand Ashok Dumbre wrote: ... > > > > +void __iomem *fwnode_iomap(struct fwnode_handle *fwnode, int > > > index) { > > > > > > > + if (is_of_node(fwnode)) > > > > + return of_iomap(to_of_node(fwnode), index); > > > > > > It seems this part should be wrapped in some ifdeffery according to > > > kbuild bot report. > > > > I see that of_iomap is wrapped in #ifdef I will fix that and send a new patch. > > I am unable to reproduce the conditions for the error shown by the kernel bot. > Not sure if I am doing something wrong. Any help/suggestion would be appreciated to fix this issue. Kbuild bot gives you a config file and command line with which it tried to build. It's quite rare that it gives you false positives (and here it's not the case, because you need to have ifdeffery like other APIs in this category have). > > > > + return NULL; > > > > +} -- With Best Regards, Andy Shevchenko