From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD91CC433FE for ; Thu, 2 Dec 2021 16:52:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359768AbhLBQ4A (ORCPT ); Thu, 2 Dec 2021 11:56:00 -0500 Received: from mga02.intel.com ([134.134.136.20]:29754 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347848AbhLBQz7 (ORCPT ); Thu, 2 Dec 2021 11:55:59 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10185"; a="223982987" X-IronPort-AV: E=Sophos;i="5.87,282,1631602800"; d="scan'208";a="223982987" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2021 08:52:33 -0800 X-IronPort-AV: E=Sophos;i="5.87,282,1631602800"; d="scan'208";a="541288981" Received: from smile.fi.intel.com ([10.237.72.184]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2021 08:52:30 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1mspIs-001SXx-Vt; Thu, 02 Dec 2021 18:51:26 +0200 Date: Thu, 2 Dec 2021 18:51:26 +0200 From: Andy Shevchenko To: Anand Ashok Dumbre Cc: "linux-kernel@vger.kernel.org" , "jic23@kernel.org" , "lars@metafoo.de" , "linux-iio@vger.kernel.org" , git , Michal Simek , "gregkh@linuxfoundation.org" , "rafael@kernel.org" , "linux-acpi@vger.kernel.org" , "heikki.krogerus@linux.intel.com" , Manish Narani Subject: Re: [PATCH v11 3/5] iio: adc: Add Xilinx AMS driver Message-ID: References: <20211124225407.17793-1-anand.ashok.dumbre@xilinx.com> <20211124225407.17793-4-anand.ashok.dumbre@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 02, 2021 at 04:32:33PM +0000, Anand Ashok Dumbre wrote: ... > > > +/** > > > + * struct ams - Driver data for xilinx-ams (1) > > > + * @base: physical base address of device > > > + * @ps_base: physical base address of PS device > > > + * @pl_base: physical base address of PL device > > > + * @clk: clocks associated with the device > > > + * @dev: pointer to device struct > > > + * @lock: to handle multiple user interaction > > > + * @intr_lock: to protect interrupt mask values > > > + * @alarm_mask: alarm configuration > > > + * @current_masked_alarm: currently masked due to alarm > > > + * @intr_mask: interrupt configuration > > > + * @ams_unmask_work: re-enables event once the event condition > > > +disappears > > > > > + * This structure contains necessary state for Sysmon driver to > > > + operate > > > > Shouldn't be this "state for Sysmon driver to operate" a summary above? > > I don't understand. (1) is not so informative, this one is better. > > > + */ -- With Best Regards, Andy Shevchenko