From: Rob Herring <robh@kernel.org>
To: Marc Zyngier <maz@kernel.org>
Cc: Biwen Li <biwen.li@nxp.com>,
devicetree@vger.kernel.org,
Chris Brandt <chris.brandt@renesas.com>,
linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Sander Vanheule <sander@svanheule.net>,
John Crispin <john@phrozen.org>,
kernel-team@android.com
Subject: Re: [PATCH v2] of/irq: Add a quirk for controllers with their own definition of interrupt-map
Date: Fri, 3 Dec 2021 11:17:45 -0600 [thread overview]
Message-ID: <YapROd/1lE/Yb0DQ@robh.at.kernel.org> (raw)
In-Reply-To: <20211201114102.13446-1-maz@kernel.org>
On Wed, 01 Dec 2021 11:41:02 +0000, Marc Zyngier wrote:
> Since 041284181226 ("of/irq: Allow matching of an interrupt-map local
> to an interrupt controller"), a handful of interrupt controllers have
> stopped working correctly. This is due to the DT exposing a non-sensical
> interrupt-map property, and their drivers relying on the kernel ignoring
> this property.
>
> Since we cannot realistically fix this terrible behaviour, add a quirk
> for the limited set of devices that have implemented this monster,
> and document that this is a pretty bad practice.
>
> Cc: Rob Herring <robh@kernel.org>
> Cc: John Crispin <john@phrozen.org>
> Cc: Biwen Li <biwen.li@nxp.com>
> Cc: Chris Brandt <chris.brandt@renesas.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Sander Vanheule <sander@svanheule.net>
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> ---
>
> Notes:
> v2: Switched over to of_device_compatible_match() as per Rob's
> request.
>
> drivers/of/irq.c | 28 ++++++++++++++++++++++++++--
> 1 file changed, 26 insertions(+), 2 deletions(-)
>
Applied, thanks!
next prev parent reply other threads:[~2021-12-03 17:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 11:41 [PATCH v2] of/irq: Add a quirk for controllers with their own definition of interrupt-map Marc Zyngier
2021-12-02 15:06 ` Geert Uytterhoeven
2021-12-03 17:17 ` Rob Herring
2021-12-03 17:29 ` Rob Herring
2021-12-03 17:17 ` Rob Herring [this message]
2021-12-13 19:59 ` Vladimir Oltean
2021-12-13 20:27 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YapROd/1lE/Yb0DQ@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=biwen.li@nxp.com \
--cc=chris.brandt@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=john@phrozen.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=sander@svanheule.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).