From: Eric Biggers <ebiggers@kernel.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
linux-doc@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH v2 5/8] docs: sysfs-block: document stable_writes
Date: Wed, 8 Dec 2021 14:34:30 -0800 [thread overview]
Message-ID: <YbEy9tKDwf5Jthl1@gmail.com> (raw)
In-Reply-To: <7d9f9469-5347-780a-c560-77fca6e7008b@acm.org>
On Wed, Dec 08, 2021 at 10:01:10AM -0800, Bart Van Assche wrote:
> On 12/7/21 4:56 PM, Eric Biggers wrote:
> > +What: /sys/block/<disk>/queue/stable_writes
> > +Date: September 2020
> > +Contact: linux-block@vger.kernel.org
> > +Description:
> > + [RW] If the device requires that memory must not be modified
> > + while it is being written out to disk, this file will contain
> > + '1'. Otherwise it will contain '0'. This file is writable for
> > + testing purposes.
>
> Hmm ... doesn't this attribute apply to the process of transferring data from
> host memory to the device instead of to writing to the disk? Whether data goes
> to the storage device cache or to the storage medium itself depends on attributes
> like FUA.
>
Yes, I meant "written out to disk" in the general sense of writeback, not in the
sense of when the data reaches its final destination. I'm not sure what the
best way to explain it is. I think it's more than just "the process of
transferring data from host memory to the device", as that is just part of a
write request, whereas stable_writes applies to whole requests. How about:
[RW] This file will contain '1' if memory must not be modified
while it is being used in a write request to this device. When
this is the case and the kernel is performing writeback of a
page, the kernel will wait for writeback to complete before
allowing the page to be modified again, rather than allowing
immediate modification as is normally the case. This
restriction arises when the device accesses the memory multiple
times where the same data must be seen every time -- for
example, once to calculate a checksum and once to actually write
the data. If no such restriction exists, this file will contain
'0'. This file is writable for testing purposes.
- Eric
next prev parent reply other threads:[~2021-12-08 22:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 0:56 [PATCH v2 0/8] docs: consolidate sysfs-block into Documentation/ABI/ Eric Biggers
2021-12-08 0:56 ` [PATCH v2 1/8] docs: sysfs-block: move to stable directory Eric Biggers
2021-12-08 0:56 ` [PATCH v2 2/8] docs: sysfs-block: sort alphabetically Eric Biggers
2021-12-08 0:56 ` [PATCH v2 3/8] docs: sysfs-block: add contact for nomerges Eric Biggers
2021-12-08 0:56 ` [PATCH v2 4/8] docs: sysfs-block: fill in missing documentation from queue-sysfs.rst Eric Biggers
2021-12-08 0:56 ` [PATCH v2 5/8] docs: sysfs-block: document stable_writes Eric Biggers
2021-12-08 18:01 ` Bart Van Assche
2021-12-08 22:34 ` Eric Biggers [this message]
2021-12-08 22:59 ` Bart Van Assche
2021-12-08 0:56 ` [PATCH v2 6/8] docs: sysfs-block: document virt_boundary_mask Eric Biggers
2021-12-08 18:33 ` Bart Van Assche
2021-12-08 22:38 ` Eric Biggers
2021-12-08 22:59 ` Bart Van Assche
2021-12-08 0:56 ` [PATCH v2 7/8] docs: block: remove queue-sysfs.rst Eric Biggers
2021-12-08 0:56 ` [PATCH v2 8/8] MAINTAINERS: add entries for block layer documentation Eric Biggers
2021-12-08 3:01 ` [PATCH v2 0/8] docs: consolidate sysfs-block into Documentation/ABI/ Martin K. Petersen
2021-12-08 18:35 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbEy9tKDwf5Jthl1@gmail.com \
--to=ebiggers@kernel.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).