From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CFD9C433FE for ; Fri, 10 Dec 2021 10:47:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238716AbhLJKvG (ORCPT ); Fri, 10 Dec 2021 05:51:06 -0500 Received: from mga07.intel.com ([134.134.136.100]:33181 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233090AbhLJKvF (ORCPT ); Fri, 10 Dec 2021 05:51:05 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10193"; a="301708807" X-IronPort-AV: E=Sophos;i="5.88,195,1635231600"; d="scan'208";a="301708807" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Dec 2021 02:47:29 -0800 X-IronPort-AV: E=Sophos;i="5.88,195,1635231600"; d="scan'208";a="612890744" Received: from smile.fi.intel.com ([10.237.72.184]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Dec 2021 02:47:27 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1mvdQ4-004SQQ-Ph; Fri, 10 Dec 2021 12:46:28 +0200 Date: Fri, 10 Dec 2021 12:46:28 +0200 From: Andy Shevchenko To: Sergey Shtylyov Cc: Damien Le Moal , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Hans de Goede , Jens Axboe Subject: Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved Message-ID: References: <20211209145937.77719-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 10, 2021 at 11:59:00AM +0300, Sergey Shtylyov wrote: > On 12/10/21 1:49 AM, Damien Le Moal wrote: > > >> platform_get_irq() will print a message when it fails. > >> No need to repeat this. > >> > >> While at it, drop redundant check for 0 as platform_get_irq() spills > >> out a big WARN() in such case. > > > > The reason you should be able to remove the "if (!irq)" test is that > > platform_get_irq() never returns 0. At least, that is what the function kdoc > > says. But looking at platform_get_irq_optional(), which is called by > > platform_get_irq(), the out label is: > > > > WARN(ret == 0, "0 is an invalid IRQ number\n"); > > return ret; > > > > So 0 will be returned as-is. That is rather weird. That should be fixed to > > return -ENXIO: > > > > if (WARN(ret == 0, "0 is an invalid IRQ number\n")) > > return -ENXIO; > > return ret; > > My unmerged patch (https://marc.info/?l=linux-kernel&m=163623041902285) does this > but returns -EINVAL instead. > > > Otherwise, I do not think that removing the "if (!irq)" hunk is safe. no ? > > Of course it isn't... It's unsubstantiated statement. The vIRQ 0 shouldn't be returned by any of those API calls. If it is the case, go and fix them, no need to workaround in each of the callers. -- With Best Regards, Andy Shevchenko