From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Jia-Ju Bai <baijiaju1990@gmail.com>
Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] fs: ext4: possible ABBA deadlock in ext4_inline_data_truncate() and ext4_punch_hole()
Date: Fri, 10 Dec 2021 13:05:03 -0500 [thread overview]
Message-ID: <YbOWz7tvA6DuXcrw@mit.edu> (raw)
In-Reply-To: <c9f25d5a-0963-5b2d-b1f0-e7c7454f7153@gmail.com>
On Fri, Dec 10, 2021 at 10:03:37AM +0800, Jia-Ju Bai wrote:
>
> Thank you very much for the detailed explanation!
> I will improve my static analysis tool for this point.
I'm not sure it will be possible to programatically detect why the
ABBA deadlock isn't possible without having the static analyzer having
a semantic understanding how the code works (so it can understand that
that code path which leads to the ABBA deadlock won't get executed).
It may very well be that being able to understand why the ABBA
deadlock can't happen in that case is equivalent to solving the
halting problem. But if you do come up with a clever way of improving
your static analysis tool, I'll be excited to see it!
Cheers,
- Ted
next prev parent reply other threads:[~2021-12-10 18:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 11:10 [BUG] fs: ext4: possible ABBA deadlock in ext4_inline_data_truncate() and ext4_punch_hole() Jia-Ju Bai
2021-12-09 17:00 ` Theodore Y. Ts'o
2021-12-10 2:03 ` Jia-Ju Bai
2021-12-10 18:05 ` Theodore Y. Ts'o [this message]
2021-12-12 12:56 ` Jia-Ju Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbOWz7tvA6DuXcrw@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=baijiaju1990@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).