From: Greg KH <gregkh@linuxfoundation.org>
To: "yekai(A)" <yekai13@huawei.com>
Cc: linux-accelerators@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linuxarm@huawei.com,
zhangfei.gao@linaro.org, wangzhou1@hisilicon.com
Subject: Re: [PATCH v3] uacce: use sysfs_emit instead of sprintf
Date: Mon, 13 Dec 2021 13:51:08 +0100 [thread overview]
Message-ID: <YbdBvNzmZn9twnej@kroah.com> (raw)
In-Reply-To: <aeaa46e2-0adc-142e-f7e2-dcb4bbf8a74f@huawei.com>
On Mon, Dec 13, 2021 at 08:05:56PM +0800, yekai(A) wrote:
>
>
> On 2021/12/6 18:47, Kai Ye wrote:
> > Use the sysfs_emit to replace sprintf. sprintf may cause
> > output defect in sysfs content, it is better to use new
> > added sysfs_emit function which knows the size of the
> > temporary buffer.
> >
> > Signed-off-by: Kai Ye <yekai13@huawei.com>
> > ---
> > changes v1->v2:
> > modfiy the comments.
> > changes v2->v3:
> > modify the "changes" lines.
> >
> > drivers/misc/uacce/uacce.c | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/misc/uacce/uacce.c b/drivers/misc/uacce/uacce.c
> > index 488eeb2811ae..281c54003edc 100644
> > --- a/drivers/misc/uacce/uacce.c
> > +++ b/drivers/misc/uacce/uacce.c
> > @@ -289,7 +289,7 @@ static ssize_t api_show(struct device *dev,
> > {
> > struct uacce_device *uacce = to_uacce_device(dev);
> >
> > - return sprintf(buf, "%s\n", uacce->api_ver);
> > + return sysfs_emit(buf, "%s\n", uacce->api_ver);
> > }
> >
> > static ssize_t flags_show(struct device *dev,
> > @@ -297,7 +297,7 @@ static ssize_t flags_show(struct device *dev,
> > {
> > struct uacce_device *uacce = to_uacce_device(dev);
> >
> > - return sprintf(buf, "%u\n", uacce->flags);
> > + return sysfs_emit(buf, "%u\n", uacce->flags);
> > }
> >
> > static ssize_t available_instances_show(struct device *dev,
> > @@ -309,7 +309,7 @@ static ssize_t available_instances_show(struct device *dev,
> > if (!uacce->ops->get_available_instances)
> > return -ENODEV;
> >
> > - return sprintf(buf, "%d\n",
> > + return sysfs_emit(buf, "%d\n",
> > uacce->ops->get_available_instances(uacce));
> > }
> >
> > @@ -318,7 +318,7 @@ static ssize_t algorithms_show(struct device *dev,
> > {
> > struct uacce_device *uacce = to_uacce_device(dev);
> >
> > - return sprintf(buf, "%s\n", uacce->algs);
> > + return sysfs_emit(buf, "%s\n", uacce->algs);
> > }
> >
> > static ssize_t region_mmio_size_show(struct device *dev,
> > @@ -326,7 +326,7 @@ static ssize_t region_mmio_size_show(struct device *dev,
> > {
> > struct uacce_device *uacce = to_uacce_device(dev);
> >
> > - return sprintf(buf, "%lu\n",
> > + return sysfs_emit(buf, "%lu\n",
> > uacce->qf_pg_num[UACCE_QFRT_MMIO] << PAGE_SHIFT);
> > }
> >
> > @@ -335,7 +335,7 @@ static ssize_t region_dus_size_show(struct device *dev,
> > {
> > struct uacce_device *uacce = to_uacce_device(dev);
> >
> > - return sprintf(buf, "%lu\n",
> > + return sysfs_emit(buf, "%lu\n",
> > uacce->qf_pg_num[UACCE_QFRT_DUS] << PAGE_SHIFT);
> > }
> >
> >
>
> Hi Hartman
>
> Could you help to take this patch?
It has only been 1 week. It is in my "to review" queue, please be
patient. Patches that actually fix things and are new features are
always a higher priority than changes like this that have no functional
change at all.
thanks,
greg k-h
prev parent reply other threads:[~2021-12-13 12:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 10:47 [PATCH v3] uacce: use sysfs_emit instead of sprintf Kai Ye
2021-12-13 12:05 ` yekai(A)
2021-12-13 12:51 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbdBvNzmZn9twnej@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-accelerators@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=wangzhou1@hisilicon.com \
--cc=yekai13@huawei.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).