From: Rob Herring <robh@kernel.org>
To: Ariel D'Alessandro <ariel.dalessandro@collabora.com>
Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, Xiubo.Lee@gmail.com,
bcousson@baylibre.com, broonie@kernel.org, festevam@gmail.com,
kuninori.morimoto.gx@renesas.com, lgirdwood@gmail.com,
michael@amarulasolutions.com, nicoleotsuka@gmail.com,
perex@perex.cz, shengjiu.wang@gmail.com, tiwai@suse.com,
tony@atomide.com
Subject: Re: [PATCH 3/4] ASoC: fsl-asoc-card: Add optional dt property for setting mclk-id
Date: Mon, 13 Dec 2021 14:37:19 -0600 [thread overview]
Message-ID: <Ybeu/1vsUzvAg2Ya@robh.at.kernel.org> (raw)
In-Reply-To: <20211203134930.128703-4-ariel.dalessandro@collabora.com>
On Fri, Dec 03, 2021 at 10:49:29AM -0300, Ariel D'Alessandro wrote:
> Sound cards may allow using different main clock inputs. In the generic
> fsl-asoc-card driver, these values are hardcoded for each specific card
> configuration.
>
> Let's make it more flexible, allowing setting mclk-id from the
> device-tree node. Otherwise, the default value for each card
> configuration is used.
>
> Signed-off-by: Ariel D'Alessandro <ariel.dalessandro@collabora.com>
> ---
> Documentation/devicetree/bindings/sound/fsl-asoc-card.txt | 1 +
> sound/soc/fsl/fsl-asoc-card.c | 6 ++++++
> 2 files changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt b/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt
> index 23d83fa7609f..b219626a5403 100644
> --- a/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt
> +++ b/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt
> @@ -82,6 +82,7 @@ Optional properties:
> - dai-format : audio format, for details see simple-card.yaml.
> - frame-inversion : dai-link uses frame clock inversion, for details see simple-card.yaml.
> - bitclock-inversion : dai-link uses bit clock inversion, for details see simple-card.yaml.
> + - mclk-id : main clock id, specific for each card configuration.
Ahh, there it is. This change and the header defines should be 1 patch
and driver changes another.
>
> Optional unless SSI is selected as a CPU DAI:
>
> diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c
> index 90cbed496f98..bb962e04d40b 100644
> --- a/sound/soc/fsl/fsl-asoc-card.c
> +++ b/sound/soc/fsl/fsl-asoc-card.c
> @@ -693,6 +693,12 @@ static int fsl_asoc_card_probe(struct platform_device *pdev)
> goto asrc_fail;
> }
>
> + /*
> + * Allow setting mclk-id from the device-tree node. Otherwise, the
> + * default value for each card configuration is used.
> + */
> + of_property_read_u32(np, "mclk-id", &priv->codec_priv.mclk_id);
> +
> /* Format info from DT is optional. */
> snd_soc_daifmt_parse_clock_provider_as_phandle(np, NULL, &bitclkprovider, &frameprovider);
> if (bitclkprovider || frameprovider) {
> --
> 2.30.2
>
>
next prev parent reply other threads:[~2021-12-13 20:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 13:49 [PATCH 0/4] fsl-asoc-card: Add optional dt property for setting mclk-id Ariel D'Alessandro
2021-12-03 13:49 ` [PATCH 1/4] dt-bindings: sound: Rename tlv320aic31xx-micbias as tlv320aic31xx Ariel D'Alessandro
2021-12-13 20:35 ` Rob Herring
2021-12-03 13:49 ` [PATCH 2/4] dt-bindings: tlv320aic31xx: Define PLL clock inputs Ariel D'Alessandro
2021-12-03 13:49 ` [PATCH 3/4] ASoC: fsl-asoc-card: Add optional dt property for setting mclk-id Ariel D'Alessandro
2021-12-13 20:37 ` Rob Herring [this message]
2021-12-13 22:44 ` Ariel D'Alessandro
2021-12-03 13:49 ` [PATCH 4/4] ASoC: fsl-asoc-card: Remove BCLK default value for tlv320aic31xx card Ariel D'Alessandro
2021-12-13 20:35 ` [PATCH 0/4] fsl-asoc-card: Add optional dt property for setting mclk-id Rob Herring
2021-12-13 22:43 ` Ariel D'Alessandro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ybeu/1vsUzvAg2Ya@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=ariel.dalessandro@collabora.com \
--cc=bcousson@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michael@amarulasolutions.com \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=shengjiu.wang@gmail.com \
--cc=tiwai@suse.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).