From: Rob Herring <robh@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: devicetree@vger.kernel.org,
"Damien Le Moal" <damien.lemoal@opensource.wdc.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE"
<bcm-kernel-feedback-list@broadcom.com>,
"Gregory Fong" <gregory.0xf0@gmail.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Marc Zyngier" <maz@kernel.org>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Lee Jones" <lee.jones@linaro.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Alessandro Zummo" <a.zummo@towertech.it>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Amit Kucheria" <amitk@kernel.org>,
"Zhang Rui" <rui.zhang@intel.com>,
"Markus Mayer" <mmayer@broadcom.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Al Cooper" <alcooperx@gmail.com>,
"Doug Berger" <opendmb@gmail.com>,
"open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)"
<linux-ide@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list:MULTIMEDIA CARD (MMC),
SECURE DIGITAL (SD) AND..." <linux-mmc@vger.kernel.org>,
"open list:PWM SUBSYSTEM" <linux-pwm@vger.kernel.org>,
"open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
<linux-crypto@vger.kernel.org>,
"open list:REAL TIME CLOCK (RTC) SUBSYSTEM"
<linux-rtc@vger.kernel.org>,
"open list:THERMAL" <linux-pm@vger.kernel.org>,
"open list:USB SUBSYSTEM" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH v3 14/15] dt-bindings: bus: Convert GISB arbiter to YAML
Date: Tue, 14 Dec 2021 13:14:20 -0600 [thread overview]
Message-ID: <YbjtDEPnDyOv/AvU@robh.at.kernel.org> (raw)
In-Reply-To: <20211208003727.3596577-15-f.fainelli@gmail.com>
On Tue, Dec 07, 2021 at 04:37:25PM -0800, Florian Fainelli wrote:
> Convert the Broadcom STB GISB bus arbiter to YAML to help with
> validation.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> .../devicetree/bindings/bus/brcm,gisb-arb.txt | 34 ----------
> .../bindings/bus/brcm,gisb-arb.yaml | 66 +++++++++++++++++++
> 2 files changed, 66 insertions(+), 34 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/bus/brcm,gisb-arb.txt
> create mode 100644 Documentation/devicetree/bindings/bus/brcm,gisb-arb.yaml
>
> diff --git a/Documentation/devicetree/bindings/bus/brcm,gisb-arb.txt b/Documentation/devicetree/bindings/bus/brcm,gisb-arb.txt
> deleted file mode 100644
> index 10f6d0a8159d..000000000000
> --- a/Documentation/devicetree/bindings/bus/brcm,gisb-arb.txt
> +++ /dev/null
> @@ -1,34 +0,0 @@
> -Broadcom GISB bus Arbiter controller
> -
> -Required properties:
> -
> -- compatible:
> - "brcm,bcm7278-gisb-arb" for V7 28nm chips
> - "brcm,gisb-arb" or "brcm,bcm7445-gisb-arb" for other 28nm chips
> - "brcm,bcm7435-gisb-arb" for newer 40nm chips
> - "brcm,bcm7400-gisb-arb" for older 40nm chips and all 65nm chips
> - "brcm,bcm7038-gisb-arb" for 130nm chips
> -- reg: specifies the base physical address and size of the registers
> -- interrupts: specifies the two interrupts (timeout and TEA) to be used from
> - the parent interrupt controller. A third optional interrupt may be specified
> - for breakpoints.
> -
> -Optional properties:
> -
> -- brcm,gisb-arb-master-mask: 32-bits wide bitmask used to specify which GISB
> - masters are valid at the system level
> -- brcm,gisb-arb-master-names: string list of the litteral name of the GISB
> - masters. Should match the number of bits set in brcm,gisb-master-mask and
> - the order in which they appear
> -
> -Example:
> -
> -gisb-arb@f0400000 {
> - compatible = "brcm,gisb-arb";
> - reg = <0xf0400000 0x800>;
> - interrupts = <0>, <2>;
> - interrupt-parent = <&sun_l2_intc>;
> -
> - brcm,gisb-arb-master-mask = <0x7>;
> - brcm,gisb-arb-master-names = "bsp_0", "scpu_0", "cpu_0";
> -};
> diff --git a/Documentation/devicetree/bindings/bus/brcm,gisb-arb.yaml b/Documentation/devicetree/bindings/bus/brcm,gisb-arb.yaml
> new file mode 100644
> index 000000000000..483b019275cd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/bus/brcm,gisb-arb.yaml
> @@ -0,0 +1,66 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/bus/brcm,gisb-arb.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom GISB bus Arbiter controller
> +
> +maintainers:
> + - Florian Fainelli <f.fainelli@gmail.com>
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - brcm,bcm7445-gisb-arb
> + - const: brcm,gisb-arb
> + - items:
> + - const: brcm,bcm7278-gisb-arb
> + - items:
> + - const: brcm,bcm7435-gisb-arb
> + - items:
> + - const: brcm,bcm7400-gisb-arb
> + - items:
> + - const: brcm,bcm7038-gisb-arb
> + - items:
> + - const: brcm,gisb-arb
All these can be 1 enum.
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + minItems: 2
> + maxItems: 3
We lost what is each interrupt. Do something like this:
minItems: 2
items:
- description: ...
- description: ...
- description: ...
> +
> + brcm,gisb-arb-master-mask:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: >
> + 32-bits wide bitmask used to specify which GISB masters are valid at the
> + system level
> +
> + brcm,gisb-arb-master-names:
> + $ref: /schemas/types.yaml#/definitions/string-array
> + description: >
> + String list of the litteral name of the GISB masters. Should match the
> + number of bits set in brcm,gisb-master-mask and the order in which they
LSB to MSB or ???
> + appear
period ^
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + gisb-arb@f0400000 {
> + compatible = "brcm,gisb-arb";
> + reg = <0xf0400000 0x800>;
> + interrupts = <0>, <2>;
> + interrupt-parent = <&sun_l2_intc>;
> + brcm,gisb-arb-master-mask = <0x7>;
> + brcm,gisb-arb-master-names = "bsp_0", "scpu_0", "cpu_0";
> + };
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2021-12-14 19:14 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 0:37 [PATCH v3 00/15] Broadcom DT bindings updates to YAML Florian Fainelli
2021-12-08 0:37 ` [PATCH v3 01/15] dt-bindings: mmc: Convert Broadcom STB SDHCI binding " Florian Fainelli
2021-12-09 10:06 ` Ulf Hansson
2022-01-05 16:39 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 02/15] dt-bindings: reset: Convert Broadcom STB reset " Florian Fainelli
2021-12-09 9:41 ` Philipp Zabel
2021-12-09 23:25 ` Florian Fainelli
2021-12-14 17:47 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 03/15] dt-bindings: pwm: Convert BCM7038 PWM binding " Florian Fainelli
2021-12-14 17:47 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 04/15] dt-bindings: rtc: Convert Broadcom STB waketimer " Florian Fainelli
2021-12-14 18:00 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 05/15] dt-bindings: gpio: Convert Broadcom STB GPIO " Florian Fainelli
2021-12-10 1:44 ` Linus Walleij
2021-12-10 15:22 ` Bartosz Golaszewski
2021-12-14 18:02 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 06/15] dt-binding: interrupt-controller: Convert BCM7038 L1 intc " Florian Fainelli
2021-12-14 18:04 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 07/15] dt-bindings: interrupt-controller: Convert BCM7120 L2 " Florian Fainelli
2021-12-14 18:06 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 08/15] dt-bindings: interrupt-controller: Merge BCM3380 with BCM7120 Florian Fainelli
2021-12-08 0:37 ` [PATCH v3 09/15] dt-bindings: interrupt-controller: Convert Broadcom STB L2 to YAML Florian Fainelli
2021-12-14 18:14 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 10/15] dt-bindings: rng: Convert iProc RNG200 " Florian Fainelli
2021-12-14 18:17 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 11/15] dt-bindings: thermal: Convert Broadcom TMON " Florian Fainelli
2021-12-14 18:18 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 12/15] ARM: dts: NSP: Rename SATA unit name Florian Fainelli
2021-12-08 1:23 ` Damien Le Moal
2021-12-08 0:37 ` [PATCH v3 13/15] dt-bindings: ata: Convert Broadcom SATA to YAML Florian Fainelli
2021-12-08 13:44 ` Rob Herring
2021-12-08 17:33 ` Florian Fainelli
2021-12-14 18:28 ` Rob Herring
2021-12-14 19:10 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 14/15] dt-bindings: bus: Convert GISB arbiter " Florian Fainelli
2021-12-14 19:14 ` Rob Herring [this message]
2021-12-08 0:37 ` [PATCH v3 15/15] dt-bindings: usb: Convert BDC " Florian Fainelli
2021-12-14 19:16 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbjtDEPnDyOv/AvU@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alcooperx@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=amitk@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@bgdev.pl \
--cc=damien.lemoal@opensource.wdc.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.0xf0@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maz@kernel.org \
--cc=mmayer@broadcom.com \
--cc=opendmb@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=rafael@kernel.org \
--cc=rjui@broadcom.com \
--cc=rui.zhang@intel.com \
--cc=sbranden@broadcom.com \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).