archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <>
To: Alexander Usyskin <>
Cc: Jani Nikula <>,
	Joonas Lahtinen <>,
	Rodrigo Vivi <>,
	David Airlie <>, Daniel Vetter <>,
	Tomas Winkler <>,
	Vitaly Lubart <>,,
Subject: Re: [PATCH 1/5] drm/i915/gsc: add gsc as a mei platform device
Date: Wed, 15 Dec 2021 15:07:14 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Dec 15, 2021 at 03:56:18PM +0200, Alexander Usyskin wrote:
> From: Tomas Winkler <>
> GSC is a graphics system controller, based on CSE, it provides
> a chassis controller for graphics discrete cards, as well as it
> supports media protection (HDCP 2.2) on selected devices.
> There are two MEI interfaces in GSC HECI1, the one that provides media
> protection and HECI2 the one that provides firmware interface.
> Both interfaces are on the BAR0 at offsets 0x00258000 and 0x00259000.
> GSC is a GT Engine (class 4: instance 6). HECI1 interrupt is signaled
> via bit 15 and HECI2 via bit 14 in the interrupt register.
> This patch exports GSC as platform device for mei driver to bind to.

This is NOT a platform device.  It is part of a PCI device, which is NOT
a platform device.  I keep having to say this.

Please use the auxbus interface instead if you want to split a PCI
device up into sub-child-devices and bind drivers to them.  That is what
it was created for, and this SHOULD have been caught by the other Intel
reviewers who signed-off on this patch.

so no, I will not ack this, it is not ok at all, sorry.

greg k-h

  reply	other threads:[~2021-12-15 14:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-15 13:56 [PATCH 0/5] Add driver for GSC controller Alexander Usyskin
2021-12-15 13:56 ` [PATCH 1/5] drm/i915/gsc: add gsc as a mei platform device Alexander Usyskin
2021-12-15 14:07   ` Greg Kroah-Hartman [this message]
2021-12-15 13:56 ` [PATCH 2/5] mei: add gsc driver Alexander Usyskin
2021-12-15 13:56 ` [PATCH 3/5] mei: gsc: setup char driver alive in spite of firmware handshake failure Alexander Usyskin
2021-12-15 13:56 ` [PATCH 4/5] mei: gsc: add runtime pm handlers Alexander Usyskin
2021-12-15 13:56 ` [PATCH 5/5] mei: gsc: retrieve the firmware version Alexander Usyskin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).