From: Borislav Petkov <bp@alien8.de>
To: Baoquan He <bhe@redhat.com>
Cc: Zhen Lei <thunder.leizhen@huawei.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, Dave Young <dyoung@redhat.com>,
Vivek Goyal <vgoyal@redhat.com>,
Eric Biederman <ebiederm@xmission.com>,
kexec@lists.infradead.org,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
devicetree@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>,
Feng Zhou <zhoufeng.zf@bytedance.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Chen Zhou <dingguo.cz@antgroup.com>
Subject: Re: [PATCH v17 03/10] x86: kdump: use macro CRASH_ADDR_LOW_MAX in functions reserve_crashkernel()
Date: Thu, 16 Dec 2021 15:58:56 +0100 [thread overview]
Message-ID: <YbtUME6fjjHjy3Kr@zn.tnic> (raw)
In-Reply-To: <20211216141115.GA18773@MiWiFi-R3L-srv>
On Thu, Dec 16, 2021 at 10:11:15PM +0800, Baoquan He wrote:
> As for the code refactoring, it can be done in another patchset.
Well, I said "future work" before having seen where this patchset is
going. So no, in that case, the usual kernel development process is:
cleanups/fixes first - new features later.
You can see for yourself that piling more crap on what is an already
unreadable mess is only going to make it worse. So, in order to avoid
the maintenance nightmare, we clean up, streamline, document and then
add the new feature and all is shiny.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2021-12-16 14:58 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 6:55 [PATCH v17 00/10] support reserving crashkernel above 4G on arm64 kdump Zhen Lei
2021-12-10 6:55 ` [PATCH v17 01/10] x86: kdump: replace the hard-coded alignment with macro CRASH_ALIGN Zhen Lei
2021-12-13 13:17 ` Baoquan He
2021-12-14 8:41 ` Leizhen (ThunderTown)
2021-12-13 14:26 ` john.p.donnelly
2021-12-13 19:54 ` Borislav Petkov
2021-12-14 9:27 ` Leizhen (ThunderTown)
2021-12-10 6:55 ` [PATCH v17 02/10] x86: kdump: make the lower bound of crash kernel reservation consistent Zhen Lei
2021-12-13 13:37 ` Baoquan He
2021-12-14 8:48 ` Leizhen (ThunderTown)
2021-12-13 14:27 ` john.p.donnelly
2021-12-14 19:07 ` Borislav Petkov
2021-12-14 19:24 ` Catalin Marinas
2021-12-15 2:10 ` Leizhen (ThunderTown)
2021-12-15 3:42 ` Baoquan He
2021-12-15 11:01 ` Catalin Marinas
2021-12-15 11:16 ` Baoquan He
2021-12-15 11:45 ` Leizhen (ThunderTown)
2021-12-10 6:55 ` [PATCH v17 03/10] x86: kdump: use macro CRASH_ADDR_LOW_MAX in functions reserve_crashkernel() Zhen Lei
2021-12-13 14:28 ` john.p.donnelly
2021-12-14 8:54 ` Baoquan He
2021-12-14 9:38 ` Borislav Petkov
2021-12-14 9:56 ` Baoquan He
2021-12-14 14:24 ` Borislav Petkov
2021-12-15 6:01 ` Baoquan He
2021-12-15 13:28 ` Borislav Petkov
2021-12-16 1:10 ` Baoquan He
2021-12-16 2:46 ` Leizhen (ThunderTown)
2021-12-16 11:07 ` Borislav Petkov
2021-12-16 12:08 ` Leizhen (ThunderTown)
2021-12-16 12:23 ` Leizhen (ThunderTown)
2021-12-16 14:48 ` Borislav Petkov
2021-12-17 2:51 ` Leizhen (ThunderTown)
2021-12-21 22:23 ` Borislav Petkov
2021-12-16 10:55 ` Borislav Petkov
2021-12-16 14:11 ` Baoquan He
2021-12-16 14:58 ` Borislav Petkov [this message]
2021-12-10 6:55 ` [PATCH v17 04/10] x86: kdump: move xen_pv_domain() check and insert_resource() to setup_arch() Zhen Lei
2021-12-13 14:29 ` john.p.donnelly
2021-12-14 11:40 ` Leizhen (ThunderTown)
2021-12-15 8:56 ` Leizhen (ThunderTown)
2021-12-15 9:22 ` Baoquan He
2021-12-10 6:55 ` [PATCH v17 05/10] x86: kdump: move reserve_crashkernel[_low]() into crash_core.c Zhen Lei
2021-12-13 14:30 ` john.p.donnelly
2021-12-14 10:45 ` Baoquan He
2021-12-14 12:38 ` Leizhen (ThunderTown)
2021-12-16 11:17 ` Borislav Petkov
2021-12-16 13:15 ` Leizhen (ThunderTown)
2021-12-16 14:51 ` Borislav Petkov
2021-12-10 6:55 ` [PATCH v17 06/10] arm64: kdump: introduce some macros for crash kernel reservation Zhen Lei
2021-12-13 14:30 ` john.p.donnelly
2021-12-10 6:55 ` [PATCH v17 07/10] arm64: kdump: reimplement crashkernel=X Zhen Lei
2021-12-13 14:31 ` john.p.donnelly
2021-12-10 6:55 ` [PATCH v17 08/10] of: fdt: Aggregate the processing of "linux,usable-memory-range" Zhen Lei
2021-12-10 16:39 ` Rob Herring
2021-12-13 14:34 ` john.p.donnelly
2021-12-10 6:55 ` [PATCH v17 09/10] of: fdt: Add memory for devices by DT property "linux,usable-memory-range" Zhen Lei
2021-12-10 16:43 ` Rob Herring
2021-12-13 14:33 ` john.p.donnelly
2021-12-10 6:55 ` [PATCH v17 10/10] kdump: update Documentation about crashkernel Zhen Lei
2021-12-13 14:34 ` john.p.donnelly
2021-12-10 7:15 ` [PATCH v17 00/10] support reserving crashkernel above 4G on arm64 kdump Kefeng Wang
2021-12-13 18:50 ` Will Deacon
2021-12-13 14:37 ` john.p.donnelly
2021-12-13 18:56 ` Catalin Marinas
2021-12-13 18:57 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbtUME6fjjHjy3Kr@zn.tnic \
--to=bp@alien8.de \
--cc=bhe@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dingguo.cz@antgroup.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=frowand.list@gmail.com \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=thunder.leizhen@huawei.com \
--cc=vgoyal@redhat.com \
--cc=wangkefeng.wang@huawei.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=zhoufeng.zf@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).