From: Rob Herring <robh@kernel.org>
To: Jesse Taube <mr.bossman075@gmail.com>
Cc: linux-imx@nxp.com, mturquette@baylibre.com, sboyd@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com,
ulf.hansson@linaro.org, aisheng.dong@nxp.com, stefan@agner.ch,
linus.walleij@linaro.org, gregkh@linuxfoundation.org,
arnd@arndb.de, olof@lixom.net, soc@kernel.org,
linux@armlinux.org.uk, abel.vesa@nxp.com,
adrian.hunter@intel.com, jirislaby@kernel.org,
giulio.benetti@benettiengineering.com,
nobuhiro1.iwamatsu@toshiba.co.jp, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v5 4/9] dt-bindings: clock: imx: Add documentation for i.MXRT1050 clock
Date: Thu, 16 Dec 2021 09:58:05 -0600 [thread overview]
Message-ID: <YbtiDa3CpVmiCkto@robh.at.kernel.org> (raw)
In-Reply-To: <20211215220538.4180616-5-Mr.Bossman075@gmail.com>
On Wed, Dec 15, 2021 at 05:05:33PM -0500, Jesse Taube wrote:
> From: Jesse Taube <mr.bossman075@gmail.com>
>
> Add DT binding documentation for i.MXRT1050 clock driver.
>
> Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>
> Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
> ---
> V1->V2:
> * Replace macros with values
> V2->V3:
> * Remove anatop
> * Use lpuart not gpt
> * include imxrt1050-clock.h
> * 2 space tabs to 4
> * Remove oneOf enum
> * Change maxItems to 2
> V3->V4:
> * Nothing done
> V4->V5:
> * Remove extra newline
> * Rename ccm to clock-controller
> * Change minItems to const
> * Change minItems to description
> * Rename file to add 1050
> * Change commit description to just 1050
> ---
> .../bindings/clock/imxrt1050-clock.yaml | 66 +++++++++++++++++++
> 1 file changed, 66 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/imxrt1050-clock.yaml
>
> diff --git a/Documentation/devicetree/bindings/clock/imxrt1050-clock.yaml b/Documentation/devicetree/bindings/clock/imxrt1050-clock.yaml
> new file mode 100644
> index 000000000000..8caf0572733b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/imxrt1050-clock.yaml
> @@ -0,0 +1,66 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/imxrt1050-clock.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Clock bindings for Freescale i.MXRT
> +
> +maintainers:
> + - Giulio Benetti <giulio.benetti@benettiengineering.com>
> + - Jesse Taube <Mr.Bossman075@gmail.com>
> +
> +description: |
> + The clock consumer should specify the desired clock by having the clock
> + ID in its "clocks" phandle cell. See include/dt-bindings/clock/imxrt*-clock.h
> + for the full list of i.MXRT clock IDs.
> +
> +properties:
> + compatible:
> + const: fsl,imxrt1050-ccm
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 2
> +
> + clocks:
> + description: 24m osc
maxItems: 1
With that,
Reviewed-by: Rob Herring <robh@kernel.org>
> +
> + clock-names:
> + const: osc
> +
> + '#clock-cells':
> + const: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> + - '#clock-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/imxrt1050-clock.h>
> +
> + clks: clock-controller@400fc000 {
> + compatible = "fsl,imxrt1050-ccm";
> + reg = <0x400fc000 0x4000>;
> + interrupts = <95>, <96>;
> + clocks = <&osc>;
> + clock-names = "osc";
> + #clock-cells = <1>;
> + };
> +
> + lpuart1: serial@40184000 {
> + compatible = "fsl,imxrt1050-lpuart";
> + reg = <0x40184000 0x4000>;
> + interrupts = <20>;
> + clocks = <&clks IMXRT1050_CLK_LPUART1>;
> + clock-names = "ipg";
> + };
> --
> 2.34.1
>
>
next prev parent reply other threads:[~2021-12-16 15:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 22:05 [PATCH v5 0/9] Add initial support for the i.MXRTxxxx SoC family starting from i.IMXRT1050 SoC Jesse Taube
2021-12-15 22:05 ` [PATCH v5 1/9] ARM: imx: Add initial support for i.MXRT10xx family Jesse Taube
2021-12-15 22:05 ` [PATCH v5 2/9] ARM: dts: imxrt1050-pinfunc: Add pinctrl binding header Jesse Taube
2021-12-15 22:05 ` [PATCH v5 3/9] dt-bindings: imx: Add clock binding for i.MXRT1050 Jesse Taube
2021-12-15 22:05 ` [PATCH v5 4/9] dt-bindings: clock: imx: Add documentation for i.MXRT1050 clock Jesse Taube
2021-12-16 15:58 ` Rob Herring [this message]
2021-12-15 22:05 ` [PATCH v5 5/9] clk: imx: Add initial support for i.MXRT1050 clock driver Jesse Taube
2021-12-16 16:07 ` Abel Vesa
2021-12-15 22:05 ` [PATCH v5 6/9] dt-bindings: serial: fsl-lpuart: add i.MXRT1050 compatible Jesse Taube
2021-12-16 20:31 ` Rob Herring
2021-12-15 22:05 ` [PATCH v5 7/9] tty: serial: fsl_lpuart: Add i.MXRT1050 support Jesse Taube
2021-12-15 22:05 ` [PATCH v5 8/9] ARM: dts: imx: Add i.MXRT1050-EVK support Jesse Taube
2021-12-15 22:05 ` [PATCH v5 9/9] ARM: imxrt_defconfig: Add i.MXRT family defconfig Jesse Taube
2021-12-16 8:26 ` [PATCH v5 0/9] Add initial support for the i.MXRTxxxx SoC family starting from i.IMXRT1050 SoC Arnd Bergmann
2021-12-16 17:33 ` [RESEND in plain-test] " Giulio Benetti
2021-12-16 21:13 ` Arnd Bergmann
2021-12-17 9:54 ` Giulio Benetti
2021-12-17 10:28 ` Arnd Bergmann
2021-12-17 11:54 ` Giulio Benetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbtiDa3CpVmiCkto@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=abel.vesa@nxp.com \
--cc=adrian.hunter@intel.com \
--cc=aisheng.dong@nxp.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=giulio.benetti@benettiengineering.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mr.bossman075@gmail.com \
--cc=mturquette@baylibre.com \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=olof@lixom.net \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=soc@kernel.org \
--cc=stefan@agner.ch \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).