From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] f2fs: Simplify bool conversion
Date: Thu, 16 Dec 2021 11:27:42 -0800 [thread overview]
Message-ID: <YbuTLr/HJO3IMI6u@google.com> (raw)
In-Reply-To: <20211215023858.33303-1-yang.lee@linux.alibaba.com>
On 12/15, Yang Li wrote:
> Fix the following coccicheck warning:
> ./fs/f2fs/sysfs.c:491:41-46: WARNING: conversion to bool not needed here
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> fs/f2fs/sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
> index 9e1cf44642ae..530c36b89bf1 100644
> --- a/fs/f2fs/sysfs.c
> +++ b/fs/f2fs/sysfs.c
> @@ -488,7 +488,7 @@ static ssize_t __sbi_store(struct f2fs_attr *a,
>
> if (!strcmp(a->attr.name, "gc_urgent_high_remaining")) {
> spin_lock(&sbi->gc_urgent_high_lock);
> - sbi->gc_urgent_high_limited = t == 0 ? false : true;
> + sbi->gc_urgent_high_limited = t != 0;
Why not this?
sbi->gc_urgent_high_limited = t;
> sbi->gc_urgent_high_remaining = t;
> spin_unlock(&sbi->gc_urgent_high_lock);
>
> --
> 2.20.1.7.g153144c
next prev parent reply other threads:[~2021-12-16 19:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 2:38 [PATCH -next] f2fs: Simplify bool conversion Yang Li
2021-12-16 19:27 ` Jaegeuk Kim [this message]
[not found] ` <fc89c7e6-ced2-40e1-9d01-496a3b60b268.yang.lee@linux.alibaba.com>
2021-12-17 16:51 ` 回复：[PATCH " Jaegeuk Kim
2021-12-17 1:12 ` [PATCH " Chao Yu
2021-12-17 16:54 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbuTLr/HJO3IMI6u@google.com \
--to=jaegeuk@kernel.org \
--cc=abaci@linux.alibaba.com \
--cc=chao@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).