From: Matthias Kaehlcke <mka@chromium.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Felipe Balbi <balbi@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Peter Chen <peter.chen@kernel.org>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Roger Quadros <rogerq@kernel.org>,
Michal Simek <michal.simek@xilinx.com>,
Ravi Chandra Sadineni <ravisadineni@chromium.org>,
Bastien Nocera <hadess@hadess.net>, Andrew Lunn <andrew@lunn.ch>,
Aswath Govindraju <a-govindraju@ti.com>,
Dmitry Osipenko <digetx@gmail.com>,
Gregory Clement <gregory.clement@bootlin.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Pawel Laszczak <pawell@cadence.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Tony Lindgren <tony@atomide.com>,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v17 7/7] usb: Specify dependencies on USB_XHCI_PLATFORM with 'depends on'
Date: Thu, 16 Dec 2021 15:56:38 -0800 [thread overview]
Message-ID: <YbvSNta4jCxizaTa@google.com> (raw)
In-Reply-To: <20211116120642.v17.7.If248f05613bbb06a44eb0b0909be5d97218f417b@changeid>
On Tue, Nov 16, 2021 at 12:07:39PM -0800, Matthias Kaehlcke wrote:
> Some USB controller drivers that depend on the xhci-plat driver
> specify this dependency using 'select' in Kconfig. This is not
> recommended for symbols that have other dependencies as it may
> lead to invalid configurations. Use 'depends on' to specify the
> dependency instead of 'select'.
>
> For dwc3 specify the dependency on USB_XHCI_PLATFORM in
> USB_DWC3_HOST and USB_DWC3_DUAL_ROLE. Also adjust the
> dependencies of USB_DWC3_CORE to make sure that at least one
> of USB_DWC3_HOST, USB_DWC3_GADGET or USB_DWC3_DUAL_ROLE can be
> selected.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> Reviewed-by: Roger Quadros <rogerq@kernel.org>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
Note: This patch has been removed from the onboard_usb_hub series,
together with "ARM: configs: Explicitly enable USB_XHCI_PLATFORM
where needed" and "arm64: defconfig: Explicitly enable
USB_XHCI_PLATFORM". These patches aren't any longer needed for the
series. If maintainers think they are useful independently from
the series please pick them or let me know what needs to be
changed to get them landed.
next prev parent reply other threads:[~2021-12-16 23:56 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 20:07 [PATCH v17 0/7] usb: misc: Add onboard_usb_hub driver Matthias Kaehlcke
2021-11-16 20:07 ` [PATCH v17 1/7] " Matthias Kaehlcke
2021-11-18 0:11 ` Doug Anderson
2021-11-18 17:52 ` Matthias Kaehlcke
2021-12-10 16:51 ` Matthias Kaehlcke
2021-11-18 18:13 ` kernel test robot
2021-11-18 18:36 ` Matthias Kaehlcke
2021-12-20 20:05 ` Dmitry Osipenko
2021-12-30 20:17 ` Matthias Kaehlcke
2022-01-01 12:23 ` Dmitry Osipenko
2022-01-12 19:00 ` Matthias Kaehlcke
2021-11-16 20:07 ` [PATCH v17 2/7] of/platform: Add stubs for of_platform_device_create/destroy() Matthias Kaehlcke
2021-11-22 17:43 ` Matthias Kaehlcke
2021-12-01 22:31 ` Matthias Kaehlcke
2021-11-16 20:07 ` [PATCH v17 3/7] usb: core: hcd: Create platform devices for onboard hubs in probe() Matthias Kaehlcke
2021-11-18 0:03 ` Doug Anderson
2021-11-16 20:07 ` [PATCH v17 4/7] arm64: dts: qcom: sc7180-trogdor: Add nodes for onboard USB hub Matthias Kaehlcke
2021-11-18 0:03 ` Doug Anderson
2021-11-18 18:43 ` Matthias Kaehlcke
2021-11-16 20:07 ` [PATCH v17 5/7] ARM: configs: Explicitly enable USB_XHCI_PLATFORM where needed Matthias Kaehlcke
2021-11-16 20:07 ` [PATCH v17 6/7] arm64: defconfig: Explicitly enable USB_XHCI_PLATFORM Matthias Kaehlcke
2021-11-16 20:07 ` [PATCH v17 7/7] usb: Specify dependencies on USB_XHCI_PLATFORM with 'depends on' Matthias Kaehlcke
2021-11-17 2:21 ` Alan Stern
2021-11-18 17:16 ` Matthias Kaehlcke
2021-12-16 23:56 ` Matthias Kaehlcke [this message]
2021-12-17 0:47 ` Dmitry Osipenko
2021-12-20 18:44 ` Matthias Kaehlcke
2021-12-20 19:59 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbvSNta4jCxizaTa@google.com \
--to=mka@chromium.org \
--cc=a-govindraju@ti.com \
--cc=andrew@lunn.ch \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=digetx@gmail.com \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@bootlin.com \
--cc=hadess@hadess.net \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=mathias.nyman@intel.com \
--cc=michal.simek@xilinx.com \
--cc=pawell@cadence.com \
--cc=peter.chen@kernel.org \
--cc=ravisadineni@chromium.org \
--cc=robh+dt@kernel.org \
--cc=rogerq@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=stern@rowland.harvard.edu \
--cc=swboyd@chromium.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).