From: Christoph Hellwig <hch@infradead.org>
To: "David E. Box" <david.e.box@linux.intel.com>
Cc: Rajat Jain <rajatja@google.com>,
Bjorn Helgaas <helgaas@kernel.org>,
francisco.munoz.ruiz@linux.intel.com,
nirmal.patel@linux.intel.com, jonathan.derrick@linux.dev,
lorenzo.pieralisi@arm.com, hch@infradead.org, kw@linux.com,
robh@kernel.org, bhelgaas@google.com,
michael.a.bottini@linux.intel.com, rafael@kernel.org,
me@adhityamohan.in, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 2/2] PCI: vmd: Override ASPM on TGL/ADL VMD devices
Date: Tue, 21 Dec 2021 23:50:39 -0800 [thread overview]
Message-ID: <YcLYz0x5oawOEHnI@infradead.org> (raw)
In-Reply-To: <9b540d4f11bb4e2e1422b641df1f5e84aa68602f.camel@linux.intel.com>
On Tue, Dec 21, 2021 at 01:11:26PM -0800, David E. Box wrote:
> The reason why BIOS is not programming these values is because when VMD is
> enabled the ports are not visible to BIOS. This would apply to any BIOS
> including those used by ChromeOS.
> And because BIOS doesn't see these ports ...
Isn't VMD enabled by the BIOS? The bios should be able see them the
same way as Linux does. But given that the whole point of VMD is to hide
these ports from Windows it obviously doesn't. For Linux and thus for
ChromeOS VMD is completely pointless, so give that the ChromeOS people
aren't as dumb as some people at Intel I'm pretty sure they won't enable
it and just use the ports as normal one and avoid this whole
self-inflicted pain.
If only Intel could give the OS a way to disable VMD at runtime and
discover the actual ports, then we would not have this whole nightmare
of having to support it.
next prev parent reply other threads:[~2021-12-22 7:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 5:55 [PATCH V4 1/2] PCI/ASPM: Add ASPM BIOS override function David E. Box
2021-12-16 5:56 ` [PATCH V4 2/2] PCI: vmd: Override ASPM on TGL/ADL VMD devices David E. Box
2021-12-16 17:26 ` Bjorn Helgaas
2021-12-16 21:24 ` David E. Box
2021-12-20 17:28 ` Bjorn Helgaas
2021-12-20 23:06 ` David E. Box
2021-12-21 2:14 ` Rajat Jain
2021-12-21 21:11 ` David E. Box
2021-12-22 7:50 ` Christoph Hellwig [this message]
2021-12-21 1:52 ` Rajat Jain
2021-12-16 17:06 ` [PATCH V4 1/2] PCI/ASPM: Add ASPM BIOS override function Bjorn Helgaas
2021-12-16 18:33 ` David E. Box
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcLYz0x5oawOEHnI@infradead.org \
--to=hch@infradead.org \
--cc=bhelgaas@google.com \
--cc=david.e.box@linux.intel.com \
--cc=francisco.munoz.ruiz@linux.intel.com \
--cc=helgaas@kernel.org \
--cc=jonathan.derrick@linux.dev \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=me@adhityamohan.in \
--cc=michael.a.bottini@linux.intel.com \
--cc=nirmal.patel@linux.intel.com \
--cc=rafael@kernel.org \
--cc=rajatja@google.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).