From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Kajol Jain <kjain@linux.ibm.com>
Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@redhat.com, jolsa@kernel.org, namhyung@kernel.org,
ak@linux.intel.com, linux-perf-users@vger.kernel.org,
maddy@linux.ibm.com, atrajeev@linux.vnet.ibm.com,
rnsastry@linux.ibm.com, yao.jin@linux.intel.com, ast@kernel.org,
daniel@iogearbox.net, songliubraving@fb.com,
kan.liang@linux.intel.com, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, paulus@samba.org
Subject: Re: [PATCH 3/4] powerpc/perf: Add encodings to represent data based on newer composite PERF_MEM_LVLNUM* fields
Date: Wed, 22 Dec 2021 09:38:39 -0300 [thread overview]
Message-ID: <YcMcT5gbv+3E7LGr@kernel.org> (raw)
In-Reply-To: <20211206091749.87585-4-kjain@linux.ibm.com>
Em Mon, Dec 06, 2021 at 02:47:48PM +0530, Kajol Jain escreveu:
> The code represent data coming from L1/L2/L3 cache hits based on
> PERF_MEM_LVL_* namespace, which is in the process of deprecation in
> the favour of newer composite PERF_MEM_{LVLNUM_,REMOTE_,SNOOPX_,HOPS_}
> fields.
Thanks, applied.
- Arnaldo
> Add data source encodings to represent L1/L2/L3 cache hits based on
> newer composite PERF_MEM_{LVLNUM_,REMOTE_,SNOOPX_,HOPS_} fields for
> power10 and older platforms
>
> Result in power9 system without patch changes:
>
> localhost:# ./perf mem report --sort="mem,sym,dso" --stdio
> # Overhead Samples Memory access Symbol Shared Object
> # ........ ............ ........................ ................................. ................
> #
> 29.51% 1 L2 hit [k] perf_event_exec [kernel.vmlinux]
> 27.05% 1 L1 hit [k] perf_ctx_unlock [kernel.vmlinux]
> 13.93% 1 L1 hit [k] vtime_delta [kernel.vmlinux]
> 13.11% 1 L1 hit [k] prepend_path.isra.11 [kernel.vmlinux]
> 8.20% 1 L1 hit [.] 00000038.plt_call.__GI_strlen libc-2.28.so
> 8.20% 1 L1 hit [k] perf_event_interrupt [kernel.vmlinux]
>
> Result in power9 system with patch changes:
>
> localhost:# ./perf mem report --sort="mem,sym,dso" --stdio
> # Overhead Samples Memory access Symbol Shared Object
> # ........ ............ ........................ .......................... ................
> #
> 36.63% 1 L2 or L2 hit [k] perf_event_exec [kernel.vmlinux]
> 25.50% 1 L1 or L1 hit [k] vtime_delta [kernel.vmlinux]
> 13.12% 1 L1 or L1 hit [k] unmap_region [kernel.vmlinux]
> 12.62% 1 L1 or L1 hit [k] perf_sample_event_took [kernel.vmlinux]
> 6.93% 1 L1 or L1 hit [k] perf_ctx_unlock [kernel.vmlinux]
> 5.20% 1 L1 or L1 hit [.] __memcpy_power7 libc-2.28.so
>
> Reviewed-by: Madhavan Srinivasan <maddy@linux.ibm.com>
> Signed-off-by: Kajol Jain <kjain@linux.ibm.com>
> ---
> arch/powerpc/perf/isa207-common.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/powerpc/perf/isa207-common.c b/arch/powerpc/perf/isa207-common.c
> index 7ea873ab2e6f..6c6bc8b7d887 100644
> --- a/arch/powerpc/perf/isa207-common.c
> +++ b/arch/powerpc/perf/isa207-common.c
> @@ -220,13 +220,13 @@ static inline u64 isa207_find_source(u64 idx, u32 sub_idx)
> /* Nothing to do */
> break;
> case 1:
> - ret = PH(LVL, L1);
> + ret = PH(LVL, L1) | LEVEL(L1) | P(SNOOP, HIT);
> break;
> case 2:
> - ret = PH(LVL, L2);
> + ret = PH(LVL, L2) | LEVEL(L2) | P(SNOOP, HIT);
> break;
> case 3:
> - ret = PH(LVL, L3);
> + ret = PH(LVL, L3) | LEVEL(L3) | P(SNOOP, HIT);
> break;
> case 4:
> if (sub_idx <= 1)
> --
> 2.27.0
--
- Arnaldo
next prev parent reply other threads:[~2021-12-22 12:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 9:17 [PATCH 0/4] perf: Add new macros for mem_hops field Kajol Jain
2021-12-06 9:17 ` [PATCH 1/4] " Kajol Jain
2021-12-10 8:21 ` Peter Zijlstra
2021-12-06 9:17 ` [PATCH 2/4] tools/perf: " Kajol Jain
2021-12-22 12:36 ` Arnaldo Carvalho de Melo
2021-12-06 9:17 ` [PATCH 3/4] powerpc/perf: Add encodings to represent data based on newer composite PERF_MEM_LVLNUM* fields Kajol Jain
2021-12-22 12:38 ` Arnaldo Carvalho de Melo [this message]
2021-12-06 9:17 ` [PATCH 4/4] powerpc/perf: Add data source encodings for power10 platform Kajol Jain
2021-12-22 12:41 ` Arnaldo Carvalho de Melo
2021-12-09 19:17 ` [PATCH 0/4] perf: Add new macros for mem_hops field Arnaldo Carvalho de Melo
2021-12-10 6:35 ` Michael Ellerman
2021-12-10 8:22 ` Peter Zijlstra
2021-12-21 12:14 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcMcT5gbv+3E7LGr@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ast@kernel.org \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=daniel@iogearbox.net \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=rnsastry@linux.ibm.com \
--cc=songliubraving@fb.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).