From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AFD4C433EF for ; Fri, 24 Dec 2021 03:27:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245562AbhLXD1G (ORCPT ); Thu, 23 Dec 2021 22:27:06 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:58470 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234159AbhLXD1F (ORCPT ); Thu, 23 Dec 2021 22:27:05 -0500 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1n0bEL-0006Os-BT; Fri, 24 Dec 2021 14:26:54 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 24 Dec 2021 14:26:53 +1100 Date: Fri, 24 Dec 2021 14:26:53 +1100 From: Herbert Xu To: Lad Prabhakar Cc: Rob Herring , "David S. Miller" , Randy Dunlap , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar Subject: Re: [PATCH] crypto: ux500 - Use platform_get_irq() to get the interrupt Message-ID: References: <20211218150625.15134-1-prabhakar.mahadev-lad.rj@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211218150625.15134-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 18, 2021 at 03:06:25PM +0000, Lad Prabhakar wrote: > platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static > allocation of IRQ resources in DT core code, this causes an issue > when using hierarchical interrupt domains using "interrupts" property > in the node as this bypasses the hierarchical setup and messes up the > irq chaining. > > In preparation for removal of static setup of IRQ resource from DT core > code use platform_get_irq() so that interrupt mapping is created on demand. > > While at it also store the IRQ number in struct cryp_device_data so that > we don't have to call platform_get_irq() frequently. > > Signed-off-by: Lad Prabhakar > --- > Hi, > > Dropping usage of platform_get_resource() was agreed based on > the discussion [0]. > > [0] https://patchwork.kernel.org/project/linux-renesas-soc/ > patch/20211209001056.29774-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ > > Cheers, > Prabhakar > --- > drivers/crypto/ux500/cryp/cryp.h | 2 ++ > drivers/crypto/ux500/cryp/cryp_core.c | 26 +++++++------------------- > 2 files changed, 9 insertions(+), 19 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt