From: Borislav Petkov <bp@alien8.de>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: tglx@linutronix.de, mingo@redhat.com,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next 1/2] x86: Use rdmsrl instead of rdmsr
Date: Tue, 28 Dec 2021 22:07:07 +0100 [thread overview]
Message-ID: <Yct8e5Z4M6YzAdCU@zn.tnic> (raw)
In-Reply-To: <20211210032208.28240-1-yang.lee@linux.alibaba.com>
On Fri, Dec 10, 2021 at 11:22:07AM +0800, Yang Li wrote:
> From: Li Yang <yang.lee@linux.alibaba.com>
>
> In the current scenario, variable 'hi' set but not used,
> rdmsrl() does not change the function, but it is more concise.
>
> Eliminate the following clang warnings:
> arch/x86/kernel/process.c:889:10: warning: variable 'hi' set but not
> used [-Wunused-but-set-variable]
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Li Yang <yang.lee@linux.alibaba.com>
> ---
> arch/x86/kernel/process.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
> index 5d481038fe0b..b415f30278d1 100644
> --- a/arch/x86/kernel/process.c
> +++ b/arch/x86/kernel/process.c
> @@ -886,7 +886,7 @@ void amd_e400_c1e_apic_setup(void)
>
> void __init arch_post_acpi_subsys_init(void)
> {
> - u32 lo, hi;
> + u32 lo;
>
> if (!boot_cpu_has_bug(X86_BUG_AMD_E400))
> return;
> @@ -896,7 +896,7 @@ void __init arch_post_acpi_subsys_init(void)
> * the machine is affected K8_INTP_C1E_ACTIVE_MASK bits are set in
> * MSR_K8_INT_PENDING_MSG.
> */
> - rdmsr(MSR_K8_INT_PENDING_MSG, lo, hi);
> + rdmsrl(MSR_K8_INT_PENDING_MSG, lo);
> if (!(lo & K8_INTP_C1E_ACTIVE_MASK))
> return;
>
> --
I believe you folks have been warned a bunch of times to think first
before acting upon a warning your silly bot catches.
Because your "fix" shows that you didn't even look at rdmsrl()'s
definition and what the second variable width is.
gcc explains it this way:
arch/x86/kernel/process.c: In function ‘arch_post_acpi_subsys_init’:
./arch/x86/include/asm/msr.h:277:11: warning: conversion from ‘long long unsigned int’ to ‘u32’ {aka ‘unsigned int’} may change value [-Wconversion]
277 | ((val) = native_read_msr((msr)))
| ^~~~~~~~~~~~~~~
arch/x86/kernel/process.c:899:2: note: in expansion of macro ‘rdmsrl’
899 | rdmsrl(MSR_K8_INT_PENDING_MSG, lo);
| ^~~~~~
so I'm ignoring all submissions from you from now on.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2021-12-28 21:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 3:22 [PATCH -next 1/2] x86: Use rdmsrl instead of rdmsr Yang Li
2021-12-10 3:22 ` [PATCH -next 2/2] x86: Fix kernel-doc Yang Li
2021-12-28 21:07 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yct8e5Z4M6YzAdCU@zn.tnic \
--to=bp@alien8.de \
--cc=abaci@linux.alibaba.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).