From: Borislav Petkov <bp@alien8.de>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: remove old CONFIG_FW_LOADER_MODULE test
Date: Tue, 11 Jan 2022 20:22:52 +0100 [thread overview]
Message-ID: <Yd3ZDNpOP6fMlfsp@zn.tnic> (raw)
In-Reply-To: <Yd3Twxj4FjYvBwuo@bombadil.infradead.org>
On Tue, Jan 11, 2022 at 11:00:19AM -0800, Luis Chamberlain wrote:
> Yeah I think this comes from the fact that modules get a respective
> _MODULE define in the generated file
> include/generated/autoconf.h
>
> For example:
>
> vagrant@kdevops-dev /data/linux-next (git::20211203-umh-fix-exitcodes)$
> grep CONFIG_CRC8 .config
> CONFIG_CRC8=m
> vagrant@kdevops-dev /data/linux-next (git::20211203-umh-fix-exitcodes)$
> grep CONFIG_CRC8 include/generated/autoconf.h
> #define CONFIG_CRC8_MODULE 1
>
> So I think the above was put in place to ask if its built-in or a
> module.
Talk about magic:
$ grep FW_LOADER .config
CONFIG_FW_LOADER=m
$ grep FW_LOADER include/generated/autoconf.h
#define CONFIG_FW_LOADER_MODULE 1
It is probably even documented somewhere that the build generates
CONFIG_%s_MODULE defines for testing in code...
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-01-11 19:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-30 9:39 [PATCH] firmware: remove old CONFIG_FW_LOADER_MODULE test Greg Kroah-Hartman
2022-01-06 14:44 ` Greg Kroah-Hartman
2022-01-11 19:00 ` Luis Chamberlain
2022-01-11 19:22 ` Borislav Petkov [this message]
2022-01-12 2:31 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yd3ZDNpOP6fMlfsp@zn.tnic \
--to=bp@alien8.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).