From: Matthias Kaehlcke <mka@chromium.org>
To: Alex Elder <elder@linaro.org>
Cc: davem@davemloft.net, kuba@kernel.org, jponduru@codeaurora.org,
avuyyuru@codeaurora.org, bjorn.andersson@linaro.org,
agross@kernel.org, cpratapa@codeaurora.org,
subashab@codeaurora.org, evgreen@chromium.org, elder@kernel.org,
netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 1/2] net: ipa: fix atomic update in ipa_endpoint_replenish()
Date: Tue, 11 Jan 2022 12:05:52 -0800 [thread overview]
Message-ID: <Yd3jICMLqZn94YsR@google.com> (raw)
In-Reply-To: <20220111192150.379274-2-elder@linaro.org>
On Tue, Jan 11, 2022 at 01:21:49PM -0600, Alex Elder wrote:
> In ipa_endpoint_replenish(), if an error occurs when attempting to
> replenish a receive buffer, we just quit and try again later. In
> that case we increment the backlog count to reflect that the attempt
> was unsuccessful. Then, if the add_one flag was true we increment
> the backlog again.
>
> This second increment is not included in the backlog local variable
> though, and its value determines whether delayed work should be
> scheduled. This is a bug.
>
> Fix this by determining whether 1 or 2 should be added to the
> backlog before adding it in a atomic_add_return() call.
>
> Fixes: 84f9bd12d46db ("soc: qcom: ipa: IPA endpoints")
> Signed-off-by: Alex Elder <elder@linaro.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
next prev parent reply other threads:[~2022-01-11 20:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 19:21 [PATCH net 0/2] net: ipa: fix two replenish bugs Alex Elder
2022-01-11 19:21 ` [PATCH net 1/2] net: ipa: fix atomic update in ipa_endpoint_replenish() Alex Elder
2022-01-11 20:05 ` Matthias Kaehlcke [this message]
2022-01-11 19:21 ` [PATCH net 2/2] net: ipa: prevent concurrent replenish Alex Elder
2022-01-11 20:20 ` Matthias Kaehlcke
2022-01-11 20:58 ` Alex Elder
2022-01-11 21:53 ` Matthias Kaehlcke
2022-01-11 21:54 ` Matthias Kaehlcke
2022-01-12 4:04 ` Jakub Kicinski
2022-01-12 13:16 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yd3jICMLqZn94YsR@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=avuyyuru@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=cpratapa@codeaurora.org \
--cc=davem@davemloft.net \
--cc=elder@kernel.org \
--cc=elder@linaro.org \
--cc=evgreen@chromium.org \
--cc=jponduru@codeaurora.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).