From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70D95C433EF for ; Thu, 6 Jan 2022 20:34:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243879AbiAFUeO (ORCPT ); Thu, 6 Jan 2022 15:34:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243810AbiAFUeN (ORCPT ); Thu, 6 Jan 2022 15:34:13 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA893C061245; Thu, 6 Jan 2022 12:34:12 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A7402B823F6; Thu, 6 Jan 2022 20:34:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1DB9AC36AE5; Thu, 6 Jan 2022 20:34:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641501250; bh=4wGBE9mrFvNDIODFoW8NjbIzKgcrJgzvtmSYFts9dtY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qTeS5TwtFbKtDqhox8GYq8van3xCGC4ovwzr9fPk8znyoeuh8HUcRy+sXC5yf3D7D 0H+XDXTQGf4EooH0dIxXYqg4KjLCyAkJXerBJ8MNeDzEhm5EqISWtBXYrUjcWw4P1k njbpByBxUUN50qjfurm/pRYD0bqbLEp/YHJnQhpnIkt5LaSt8qM2IdQ9ESA4UpVekB HljzyV2+0xcEBP6d2KRX9h/8I2ILUFoVw+rqySKizA6uME/XbKLPi0AlvnO2vldT1c zyM7LCa7iK47LV8XSiwlwi6I4L6vC9jyk+iE/dJXAEPu7qKxdhtvcHDFrqAIPaxqoH LKP3R9blq853g== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 3959440B92; Thu, 6 Jan 2022 17:34:08 -0300 (-03) Date: Thu, 6 Jan 2022 17:34:08 -0300 From: Arnaldo Carvalho de Melo To: Krister Johansen Cc: Riccardo Mancini , Ian Rogers , Namhyung Kim , Peter Zijlstra , Ingo Molnar , Mark Rutland , Jiri Olsa , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH 01/20] perf nsinfo: fix refcounting Message-ID: References: <55223bc8821b34ccb01f92ef1401c02b6a32e61f.1626343282.git.rickyman7@gmail.com> <20220105061942.GA20464@templeofstupid.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Jan 06, 2022 at 05:27:43PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Jan 04, 2022 at 10:19:42PM -0800, Krister Johansen escreveu: > > On Thu, Jul 15, 2021 at 04:20:24PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Thu, Jul 15, 2021 at 04:02:16PM -0300, Arnaldo Carvalho de Melo escreveu: > > > > Em Thu, Jul 15, 2021 at 06:07:06PM +0200, Riccardo Mancini escreveu: > > > > > ASan reports a memory leak of nsinfo during the execution of the perf > > > > > test "31: Lookup mmap thread". > > > > > The leak is caused by a refcounted variable being replaced without > > > > > dropping the refcount. > > > > > > > > This patch makes sure that the refcnt of nsinfo is decreased whenever > > > > > a refcounted variable is replaced with a new value. > > > > > > > So, there are multiple fixes in just one patch, I'll split it into > > > > three, no need to resend. > > > > > > > I'll try and check if finding Fixes: for the three is easy, that way > > > > stable@vger.kernel.org will figure out which of the supported releases > > > > need each of them. > > > > > > The second is at the end of this message, and looking at it I think > > > there is a problem with where this nsinfo reference is stored, it should > > > be in the 'struct map', that is per-thread, not in the 'struct dso', > > > that may be shared by multiple 'struct map's in different cgroups, so we > > > can't set dso->nsinfo in map__new(), right? Kristen? > > > > Apologies for the long delayed reply, and for the hassle that this has > > caused. > > > > You're right, Arnaldo, that namespace mapping could differ on a per > > thread basis. If the dso objects are intended to be read by multiple > > threads with different views of the target process's namespaces. With > > containers, though, there might be many different versions of the same > > object with the same filename, and the only ways we can disambiguate are > > through the build-ids or by ensuring that the dso refers to a single > > pid and mount namespace. I may have erred in assuming that all of > > perf's threads would be able to access the target namespace via the same > > identifiers. Is that what's going on here? > > yeah, I think using build-ids, when available is the way to go, and > since we can almost take it for granted (haven't checked) that it will > be present, as I think gcc/clang adds them by default, seems the way to > go. > > That or somehow have the DSO list to be perf namespace. To be by namespace, sorry. But having it by build-id seems the more sensible way to go, so that we can avoid having multiple instances of the same DSO in multiple namespaces, which should be common. I.e. continue to have a perf 'struct machine' DSO list instead of moving to having the namespace hierarchy represented under 'struct machine' since we have a way to uniquify DSOs, the build id. One way or the other, nsinfo shouldn't be stored in DSOs, its a map property, which in turn is a thread property. I.e. please consider thinking about moving it to 'struct map', would you try it, please? - Arnaldo > - Arnaldo > > > -K > > > > > > > commit 280f3933661f9ca9563ed04ce82313fdbcbb8f75 > > > Author: Riccardo Mancini > > > Date: Thu Jul 15 18:07:06 2021 +0200 > > > > > > perf map: Fix dso->nsinfo refcounting > > > > > > ASan reports a memory leak of nsinfo during the execution of > > > > > > # perf test "31: Lookup mmap thread" > > > > > > The leak is caused by a refcounted variable being replaced without > > > dropping the refcount. > > > > > > This patch makes sure that the refcnt of nsinfo is decreased whenever a > > > refcounted variable is replaced with a new value. > > > > > > Signed-off-by: Riccardo Mancini > > > Fixes: bf2e710b3cb8445c ("perf maps: Lookup maps in both intitial mountns and inner mountns.") > > > Cc: Ian Rogers > > > Cc: Jiri Olsa > > > Cc: Krister Johansen > > > Cc: Mark Rutland > > > Cc: Namhyung Kim > > > Cc: Peter Zijlstra > > > Link: http://lore.kernel.org/lkml/55223bc8821b34ccb01f92ef1401c02b6a32e61f.1626343282.git.rickyman7@gmail.com > > > Signed-off-by: Arnaldo Carvalho de Melo > > > > > > diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c > > > index 8af693d9678cefe0..72e7f3616157ead4 100644 > > > --- a/tools/perf/util/map.c > > > +++ b/tools/perf/util/map.c > > > @@ -192,6 +192,8 @@ struct map *map__new(struct machine *machine, u64 start, u64 len, > > > if (!(prot & PROT_EXEC)) > > > dso__set_loaded(dso); > > > } > > > + > > > + nsinfo__put(dso->nsinfo); > > > dso->nsinfo = nsi; > > > > > > if (build_id__is_defined(bid)) > > > > > -- > > - Arnaldo -- - Arnaldo