Re: [PATCH v7 3/3] mmc: Add driver for LiteX's LiteSDCard interface

From: "Gabriel L. Somlo" <gsomlo@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	linux-mmc <linux-mmc@vger.kernel.org>,
	Karol Gugala <kgugala@antmicro.com>,
	Mateusz Holenko <mholenko@antmicro.com>,
	Kamil Rakoczy <krakoczy@antmicro.com>,
	mdudek@internships.antmicro.com,
	Paul Mackerras <paulus@ozlabs.org>, Joel Stanley <joel@jms.id.au>,
	Stafford Horne <shorne@gmail.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	david.abdurachmanov@sifive.com,
	Florent Kermarrec <florent@enjoy-digital.fr>,
	Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH v7 3/3] mmc: Add driver for LiteX's LiteSDCard interface
Date: Fri, 7 Jan 2022 16:14:20 -0500	[thread overview]
Message-ID: <YditLMRpj0BaG9O0@errol.ini.cmu.edu> (raw)
In-Reply-To: <CAHp75VfBUomALtdhRXN-Z12RDAvLUiNHzazK0Mit6ExzRUTtRw@mail.gmail.com>

On Fri, Jan 07, 2022 at 10:54:12PM +0200, Andy Shevchenko wrote:
> On Fri, Jan 7, 2022 at 7:06 PM Gabriel Somlo <gsomlo@gmail.com> wrote:
> >
> > LiteX (https://github.com/enjoy-digital/litex) is a SoC framework
> > that targets FPGAs. LiteSDCard is a small footprint, configurable
> > SDCard core commonly used in LiteX designs.
> >
> > The driver was first written in May 2020 and has been maintained
> > cooperatively by the LiteX community. Thanks to all contributors!
> 
> ...
> 
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * LiteX LiteSDCard driver
> > + *
> > + * Copyright (C) 2019-2020 Antmicro <contact@antmicro.com>
> > + * Copyright (C) 2019-2020 Kamil Rakoczy <krakoczy@antmicro.com>
> > + * Copyright (C) 2019-2020 Maciej Dudek <mdudek@internships.antmicro.com>
> > + * Copyright (C) 2020 Paul Mackerras <paulus@ozlabs.org>
> > + * Copyright (C) 2020-2021 Gabriel Somlo <gsomlo@gmail.com>
> 
> > + *
> 
> I guess I have commented on this and there was no discussion about the
> necessity of this blank line. I dunno what else has been ignored, so I
> will wait either for the continuation of the discussion (as per v6) or
> amending code in v8.

Yeah, not sure how that got lost, it "should have" been in v7 already,
but will definitely be in v8... :)

BTW, I also added the `bit.h` include per your explanation, and removed
all the `Cc:` lines from the commit blurb (not sure when it's actually
appropriate to put those in vs. just cc-ing people from `git send-email`,
but I have no strong feelings about it of my own :)

> > + */
> 
> ...
> 
> On top of that it might still be the ordering issues in the error path
> of ->probe() and in ->remove(). I believe we will likely see v8.

I'll need to follow your bread crumbs on ordering and `of_match_table`
(also in some of the other emails you've sent in this thread),
and will send out v8 once I've made some sense of it all...

Thanks much,
--Gabriel