From: Jarkko Sakkinen <jarkko@kernel.org>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: Nayna Jain <nayna@linux.ibm.com>,
linux-integrity@vger.kernel.org, keyrings@vger.kernel.org,
dhowells@redhat.com, linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, dimitri.ledkov@canonical.com,
seth@forshee.me, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v7 1/3] certs: export load_certificate_list() to be used outside certs/
Date: Tue, 11 Jan 2022 04:22:56 +0200 [thread overview]
Message-ID: <YdzqADeSwTc0egkw@iki.fi> (raw)
In-Reply-To: <4ba63271bdf06fa8ae98c5cbd60d7b91bdbe75f7.camel@linux.ibm.com>
On Sun, Jan 09, 2022 at 06:49:23AM -0500, Mimi Zohar wrote:
> Hi Jarkko,
>
> On Sat, 2022-01-08 at 15:55 +0200, Jarkko Sakkinen wrote:
> > On Wed, Jan 05, 2022 at 12:54:08PM -0500, Nayna Jain wrote:
> > > load_certificate_list() parses certificates embedded in the kernel
> > > image to load them onto the keyring.
> > >
> > > Commit "2565ca7f5ec1 (certs: Move load_system_certificate_list to a common
> > > function)" made load_certificate_list() a common function in the certs/
> > > directory. Now, export load_certificate_list() outside certs/ to be used
> > > by load_platform_certificate_list() which is added later in the patchset.
> >
> > Also, please describe the specific use it will be used. Patchset is not
> > a valid cross-reference in this context.
>
> The specific usecase scenario is described in the cover letter. Is
> that what you're looking for?
You cannot refer to "a patch set" in the long description. It's by all
practical means a dead ref after some years. The commit messages are
meant for commit log to help to understand the history of changes.
This does not do that job. Neither a cover letter helps with this.
/Jarkko
next prev parent reply other threads:[~2022-01-11 2:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 17:54 [PATCH v7 0/3] integrity: support including firmware ".platform" keys at build time Nayna Jain
2022-01-05 17:54 ` [PATCH v7 1/3] certs: export load_certificate_list() to be used outside certs/ Nayna Jain
2022-01-08 13:54 ` Jarkko Sakkinen
2022-01-10 16:12 ` Nayna
2022-01-11 2:25 ` Jarkko Sakkinen
2022-01-11 2:25 ` Jarkko Sakkinen
2022-01-08 13:55 ` Jarkko Sakkinen
2022-01-09 11:49 ` Mimi Zohar
2022-01-11 2:22 ` Jarkko Sakkinen [this message]
2022-01-05 17:54 ` [PATCH v7 2/3] integrity: make integrity_keyring_from_id() non-static Nayna Jain
2022-01-05 17:54 ` [PATCH v7 3/3] integrity: support including firmware ".platform" keys at build time Nayna Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdzqADeSwTc0egkw@iki.fi \
--to=jarkko@kernel.org \
--cc=dhowells@redhat.com \
--cc=dimitri.ledkov@canonical.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=lkp@intel.com \
--cc=nayna@linux.ibm.com \
--cc=seth@forshee.me \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).