From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4465DC433EF for ; Mon, 24 Jan 2022 07:39:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241804AbiAXHjb (ORCPT ); Mon, 24 Jan 2022 02:39:31 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:53574 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241928AbiAXHja (ORCPT ); Mon, 24 Jan 2022 02:39:30 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 66540B80AE3 for ; Mon, 24 Jan 2022 07:39:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A648C340E1; Mon, 24 Jan 2022 07:39:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643009968; bh=nFHm6RHUSNQ1og2wVgFqUMQD88dXh4tFDBloBi//UD0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FD8bb9B10hlwCgrjWesAD4NKgowsDjbSPhz148C7nWnMCQcMEc9a02PGuQ6SHzzSr jqryY9EZLNIyDZWfFIm2rihgatCre3XdLSvyJjZysnepwkTrm0xfcz64Xy4vXTvQ4P FYk5mCvYDNHf32FSC0aHNQctMLL70e/tp0SQeNoM= Date: Mon, 24 Jan 2022 08:39:16 +0100 From: Greg Kroah-Hartman To: ratnesh-r1 Cc: devel@driverdev.osuosl.org, Todd Kjos , linux-kernel@vger.kernel.org, Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Joel Fernandes , Martijn Coenen , Christian Brauner Subject: Re: [PATCH] staging: android: ashmem: Declared file operation with const keyword Message-ID: References: <1643008187-75859-1-git-send-email-me.ratnesh682@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1643008187-75859-1-git-send-email-me.ratnesh682@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 23, 2022 at 11:09:47PM -0800, ratnesh-r1 wrote: > warning found by checkpatch.pl script. > > Signed-off-by: ratnesh-r1 > --- > drivers/staging/android/ashmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c > index c05a214..f9cfa15 100644 > --- a/drivers/staging/android/ashmem.c > +++ b/drivers/staging/android/ashmem.c > @@ -367,7 +367,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr, > > static int ashmem_mmap(struct file *file, struct vm_area_struct *vma) > { > - static struct file_operations vmfile_fops; > + static const struct file_operations vmfile_fops; > struct ashmem_area *asma = file->private_data; > int ret = 0; > > -- > 2.7.4 > > _______________________________________________ > devel mailing list > devel@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch breaks the build. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot