From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F16F1C433EF for ; Fri, 14 Jan 2022 16:10:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243146AbiANQKV (ORCPT ); Fri, 14 Jan 2022 11:10:21 -0500 Received: from mga01.intel.com ([192.55.52.88]:62406 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232390AbiANQKT (ORCPT ); Fri, 14 Jan 2022 11:10:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642176619; x=1673712619; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=VuM59CA5P02uN+pfSy6KjURQRN07fGepNkmo2Y2bY9w=; b=kt6s+rNLj+6pfqoqgFXdFhIr/AUsPc0oEeIBpvObr2sZ6grpgay/+IXV C3T7VCvQ4WbxEwp8vIu+hZ/Uqr9Ei6L3Hyt1nhT35HqDjGzSA6uighgUr epalW+YAD+2nR7trjI0QX86yCB+FntkbA6qmkvGAEsD4s1AW+cWmIKQbh 3Qr0uyt02UWXn5cYEqZvERHSmEQFmLHkq0qg6r6ddX1e9cMzkWU9bOKZf 0rEgtr8xmJw1QovY/NrleIC9l3JkZNge/Jom8w1teXlgVu8Y21JIeZZsV PXwuL/iDl6XpwofmREMItY2j3Pe5LIUrRwFVpSs02y8F4FBo6vavWZsB7 A==; X-IronPort-AV: E=McAfee;i="6200,9189,10226"; a="268637630" X-IronPort-AV: E=Sophos;i="5.88,289,1635231600"; d="scan'208";a="268637630" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2022 08:10:19 -0800 X-IronPort-AV: E=Sophos;i="5.88,289,1635231600"; d="scan'208";a="577316857" Received: from smile.fi.intel.com ([10.237.72.61]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2022 08:10:12 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1n8P6O-00AiC0-2o; Fri, 14 Jan 2022 18:06:56 +0200 Date: Fri, 14 Jan 2022 18:06:55 +0200 From: Andy Shevchenko To: Simon Ser Cc: Tomohito Esaki , dri-devel@lists.freedesktop.org, Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Ben Skeggs , Michel =?iso-8859-1?Q?D=E4nzer?= , Qingqing Zhuo , Bas Nieuwenhuizen , Mark Yacoub , Sean Paul , Evan Quan , Petr Mladek , Sakari Ailus , Lee Jones , Abhinav Kumar , Dmitry Baryshkov , Rob Clark , amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org, Daniel Stone , Laurent Pinchart , Damian Hobson-Garcia , Takanari Hayama Subject: Re: [RFC PATCH v3 2/3] drm: add support modifiers for drivers whose planes only support linear layout Message-ID: References: <20220114101753.24996-1-etom@igel.co.jp> <20220114101753.24996-3-etom@igel.co.jp> <7eljcd3F4aWL2jjBRwr3DISmyt0XPWFIH1_kebFGqZTJXLZRx0bm_8c8yaIuEuH8rS0MaJhU6SY1y-fc6U_zCLaKgoLM124nZpr0H91nSjw=@emersion.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 14, 2022 at 03:42:54PM +0000, Simon Ser wrote: > On Friday, January 14th, 2022 at 16:17, Andy Shevchenko wrote: > > > On Fri, Jan 14, 2022 at 03:07:21PM +0000, Simon Ser wrote: > > > On Friday, January 14th, 2022 at 15:16, Andy Shevchenko wrote: > > > > > > > Why not enum? > > > > > > There is no enum for DRM format modifiers. > > > > I'm not sure how this prevents to use enum in the code instead of const u64. > > Any specific reason for that? > > I'm not sure how one would use an enum as the array item type, when there is no > defined enum type. > > Moreover, all the rest of DRM uses uint64 for modifiers. Ah, I see now. This is an array that filled by predefined values. Thanks for explanation. -- With Best Regards, Andy Shevchenko