archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <>
To: Arnd Bergmann <>
Cc: Linux Kernel Mailing List <>,
	linux-arch <>,
	Linus Torvalds <>,
	Greg Kroah-Hartman <>,
	Nathan Chancellor <>,
	Andrew Morton <>,
	Peter Zijlstra <>,
	Ard Biesheuvel <>,
	Josh Poimboeuf <>,
	Jonathan Corbet <>
Subject: Re: [ANNOUNCE] "Fast Kernel Headers" Tree -v2
Date: Wed, 19 Jan 2022 13:31:41 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

* Arnd Bergmann <> wrote:

> > I tried to avoid as many low level headers as possible from the main 
> > types headers - and the get_order() functionality also brings in bitops 
> > definitions, which I'm still hoping to be able to reduce from its 
> > current ~95% utilization in a distro kernel ...
> Agreed, I think reducing bitops.h and atomic.h usage is fairly important, 
> I think these are even bigger on arm64 than on x86.

So what I'm using for 'header complexity metrics' is rather simple: passing 
-P -H to the preprocessor: stripping comments & not generating 
line-markers, and then counting linecount.

Line-markers should *probably* remain, because the real build is generating 
them too - but I wanted to gain a crude & easily available metric to 
measure 'first-pass parsing complexity'. That's I think where most of the 
header bloat is concentrated: later passes don't really get any of the 
unused header definitions passed along. (But maybe this is an invalid 
assumption, because compiler warnings do get generated by later passes, and 
they are generated for mostly-unused header inlines too.)

If we include comments & line-markers then the bloat goes up by another 

 kepler:~/mingo.tip.git> ./st include/linux/sched.h 
  #include <linux/sched.h>                | LOC:  2,186 | headers:  118
 kepler:~/mingo.tip.git> ./st include/linux/sched.h 
  #include <linux/sched.h>                | LOC:  4,092 | headers:    0

> > We could add <linux/page_api.h> as well, as a standardized header. We 
> > already have page_types.h and et_order() is a page types API.
> More generally speaking, do you have a plan for how to document which 
> header to include for getting a particular symbol that is provided by a 
> header we don't want to include directly? I think iwyu has a particular 
> notation for it, but when I looked at using that in 2020 I decided it 
> wouldn't scale to the size of the kernel. I did my own shell script with 
> a long list of regex patterns, but I'm not convinced about that approach 
> either.

Yeah, I don't think we should do much that hurts general usability of 
headers: each symbol has a primary "natural" header, and .c code and other 
headers are encouraged but not strictly required to include that.



  reply	other threads:[~2022-01-19 12:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-08 16:26 [ANNOUNCE] "Fast Kernel Headers" Tree -v2 Ingo Molnar
2022-01-10 22:03 ` Arnd Bergmann
2022-01-11 16:23   ` Arnd Bergmann
2022-01-11 17:08     ` David Laight
2022-01-13  8:27     ` Ingo Molnar
2022-01-13  9:20       ` Arnd Bergmann
2022-01-19 12:31         ` Ingo Molnar [this message]
2022-01-19 17:20           ` Arnd Bergmann
2022-01-22  9:18             ` Ingo Molnar
2022-01-13  8:57   ` Ingo Molnar
2022-01-13 10:16     ` Arnd Bergmann
2022-03-15 10:35 ` [TREE] "Fast Kernel Headers" Tree -v3 Ingo Molnar
2022-03-22  7:59   ` Kari Argillander
2022-03-22 15:37     ` Randy Dunlap
2022-03-22 16:22       ` Kari Argillander
2022-03-22 19:03         ` Kari Argillander
2023-11-04  9:07           ` Lucas Tanure

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).