From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEFFAC433F5 for ; Thu, 20 Jan 2022 15:48:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376780AbiATPsz (ORCPT ); Thu, 20 Jan 2022 10:48:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376526AbiATPsy (ORCPT ); Thu, 20 Jan 2022 10:48:54 -0500 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DBEDC06161C for ; Thu, 20 Jan 2022 07:48:54 -0800 (PST) Received: by mail-ed1-x534.google.com with SMTP id cx27so30703337edb.1 for ; Thu, 20 Jan 2022 07:48:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Bf+aPX+mUMycYg4Pnh8QdB/etAdn0UYI9odfp2ic0RU=; b=VuHmjh0SAY/OibGfI272b2yxxqa4fWVJoHrJXAIVhmI2uq7mgBCjhYultf0nE+HSv9 XM59BOs42OGYgfIzLdRlVeX7FzHjat1ZIG3kRpD6fkWw/D3BFLhtWwkbrzlHfFp7+oF7 jJozod36Z8nRN0FbLHkTEacY4JArvixbnLcdI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=Bf+aPX+mUMycYg4Pnh8QdB/etAdn0UYI9odfp2ic0RU=; b=2VuUvsv0Q1YyzdJS8C7tJCrVM7TPwN+0jOappaswrsnE725fwETVVfZvi5CvxLSxO2 AmaMwz8+pYcznu7IYxDt8qfHoafTgfn00Z+Ue/Nvh4vr3smjpJGHXFj8wsn7XEj38qTd c977jsWaUDzaRbR9XPGPbuoeFiOtoE4JgHzhrxCDMCeJxt0BSZ9xFemseP70NVH3KDqk 8GefdJL93MdHkSGbLGjOE92bTb51gTlpAKhTEC9EhKCjfYCD+2GKPx4mj1geiRHNOnXO J8/Cq/nM4GejsF6kpdCbk01ULfdxXgn921C2MrrCPmVao0skQbnDSRXbYbS/MVo59g9v 9IaQ== X-Gm-Message-State: AOAM532ZyW7axU0ratNLUeoFnRajH/dexD/XQd1rGFpaB00xz4vRneh3 7fhtMDjG3fu9wVDx+/p89giv5Q== X-Google-Smtp-Source: ABdhPJzhMjhzCED4OmXlcjcUzvJnwaTB8+5wMXtz4qIarfHZTG8xg7ac5tSmz+CD+nIsB34bqh7XKQ== X-Received: by 2002:a17:907:ea4:: with SMTP id ho36mr2995567ejc.140.1642693732656; Thu, 20 Jan 2022 07:48:52 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id u17sm1144874ejb.31.2022.01.20.07.48.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jan 2022 07:48:52 -0800 (PST) Date: Thu, 20 Jan 2022 16:48:50 +0100 From: Daniel Vetter To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: Ira Weiny , David Airlie , Patrik Jakobsson , Rob Clark , Sean Paul , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org Subject: Re: [Intel-gfx] [PATCH 0/7] DRM kmap() fixes and kmap_local_page() conversions Message-ID: Mail-Followup-To: Christian =?iso-8859-1?Q?K=F6nig?= , Ira Weiny , David Airlie , Patrik Jakobsson , Rob Clark , Sean Paul , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org References: <20211210232404.4098157-1-ira.weiny@intel.com> <20220119165356.GD209936@iweiny-DESK2.sc.intel.com> <20220119235542.GF209936@iweiny-DESK2.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Operating-System: Linux phenom 5.10.0-8-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 20, 2022 at 09:16:35AM +0100, Christian König wrote: > Am 20.01.22 um 00:55 schrieb Ira Weiny: > > On Wed, Jan 19, 2022 at 06:24:22PM +0100, Daniel Vetter wrote: > > > On Wed, Jan 19, 2022 at 08:53:56AM -0800, Ira Weiny wrote: > > > > On Fri, Dec 10, 2021 at 03:23:57PM -0800, 'Ira Weiny' wrote: > > > > > From: Ira Weiny > > > > > > > > > > This series starts by converting the last easy kmap() uses to > > > > > kmap_local_page(). > > > > > > > > > > There is one more call to kmap() wrapped in ttm_bo_kmap_ttm(). Unfortunately, > > > > > ttm_bo_kmap_ttm() is called in a number of different ways including some which > > > > > are not thread local. I have a patch to convert that call. However, it is not > > > > > straight forward so it is not included in this series. > > > > > > > > > > The final 2 patches fix bugs found while working on the ttm_bo_kmap_ttm() > > > > > conversion. > > > > Gentile ping on this series? Will it make this merge window? > > > I think this fell through the cracks and so no. Note that generally we > > > feature-freeze drm tree around -rc6 anyway for the upcoming merge window, > > > so you were cutting this all a bit close anyway. > > Ok, No problem. I just had not heard if this was picked up or not. > > > > > Also looks like the ttm > > > kmap caching question didn't get resolved? > > I'm sorry I thought it was resolve for this series. Christian said the patches > > in this series were "a good bug fix" even if not strictly necessary.[1] Beyond > > this series I was discussing where to go from here, and is it possible to go > > further with more changes.[2] At the moment I don't think I will. > > > > Christian did I misunderstand? I can drop patch 6 and 7 if they are not proper > > bug fixes or at least clarifications to the code. > > Yeah, it is indeed a correct cleanup. I would just *not* put a CC stable on > it because it doesn't really fix anything. Ok can you pls get the amd/radeon ones stuffed into alex' tree? Or do we want to put all the ttm ones into drm-misc instead? -Daniel > > Christian. > > > > > Ira > > > > [1] https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Flkml%2Fc3b173ea-6509-ebbe-b5f9-eeb29f1ce57e%40amd.com%2F&data=04%7C01%7Cchristian.koenig%40amd.com%7C5e0192210d4640adb88b08d9dba734b1%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637782333459591089%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=4p7jCB6pB4nlcUtLWh6K2Sso9X%2BsRSK7mcD8UavzztQ%3D&reserved=0 > > [2] https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Flkml%2F20211215210949.GW3538886%40iweiny-DESK2.sc.intel.com%2F&data=04%7C01%7Cchristian.koenig%40amd.com%7C5e0192210d4640adb88b08d9dba734b1%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637782333459591089%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=6%2BGfSKshg8Xr%2FXJshiU28yHzbg2HcVisVJLDU6tVUT4%3D&reserved=0 > > > > > Anyway if patches are stuck resend with RESEND and if people still don't > > > pick them up poke me and I'll apply as fallback. > > > > > > Cheers, Daniel > > > > > > > Thanks, > > > > Ira > > > > > > > > > > > > > > Ira Weiny (7): > > > > > drm/i915: Replace kmap() with kmap_local_page() > > > > > drm/amd: Replace kmap() with kmap_local_page() > > > > > drm/gma: Remove calls to kmap() > > > > > drm/radeon: Replace kmap() with kmap_local_page() > > > > > drm/msm: Alter comment to use kmap_local_page() > > > > > drm/amdgpu: Ensure kunmap is called on error > > > > > drm/radeon: Ensure kunmap is called on error > > > > > > > > > > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 8 ++++---- > > > > > drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 1 + > > > > > drivers/gpu/drm/gma500/gma_display.c | 6 ++---- > > > > > drivers/gpu/drm/gma500/mmu.c | 8 ++++---- > > > > > drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 4 ++-- > > > > > drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 8 ++++---- > > > > > drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 4 ++-- > > > > > drivers/gpu/drm/i915/gt/shmem_utils.c | 4 ++-- > > > > > drivers/gpu/drm/i915/i915_gem.c | 8 ++++---- > > > > > drivers/gpu/drm/i915/i915_gpu_error.c | 4 ++-- > > > > > drivers/gpu/drm/msm/msm_gem_submit.c | 4 ++-- > > > > > drivers/gpu/drm/radeon/radeon_ttm.c | 4 ++-- > > > > > drivers/gpu/drm/radeon/radeon_uvd.c | 1 + > > > > > 13 files changed, 32 insertions(+), 32 deletions(-) > > > > > > > > > > -- > > > > > 2.31.1 > > > > > > > > -- > > > Daniel Vetter > > > Software Engineer, Intel Corporation > > > https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fblog.ffwll.ch%2F&data=04%7C01%7Cchristian.koenig%40amd.com%7C5e0192210d4640adb88b08d9dba734b1%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637782333459591089%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=NLqm91HCdllhW%2BrQ8aHMLXhYGkOJrYffpjsIJZWaFBc%3D&reserved=0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch