From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Zhou Qingyang <zhou1615@umn.edu>
Cc: kjlu@umn.edu, Benoit Parrot <bparrot@ti.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: ti-vpe: cal: Fix a NULL pointer dereference in cal_ctx_v4l2_init_formats()
Date: Wed, 26 Jan 2022 02:39:41 +0200 [thread overview]
Message-ID: <YfCYTfnQQx8wuoD3@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20220124172001.62457-1-zhou1615@umn.edu>
Hi Zhou,
Thank you for the patch.
On Tue, Jan 25, 2022 at 01:20:01AM +0800, Zhou Qingyang wrote:
> In cal_ctx_v4l2_init_formats(), devm_kzalloc() is assigned to fw and there
What do you mean by "fw" here ? It could be replaced with "is assigned
to ctx->active_fmt". If you're fine with this change, there's no need to
resend, I can fix this when applying.
> is a dereference of it after that, which could lead to NULL pointer
> dereference on failure of devm_kzalloc().
>
> Fix this bug by adding a NULL check of ctx->active_fmt.
>
> This bug was found by a static analyzer.
>
> Builds with 'make allyesconfig' show no new warnings,
> and our static analyzer no longer warns about this code.
>
> Fixes: 7168155002cf ("media: ti-vpe: cal: Move format handling to cal.c and expose helpers")
> Signed-off-by: Zhou Qingyang <zhou1615@umn.edu>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> --
> The analysis employs differential checking to identify inconsistent
> security operations (e.g., checks or kfrees) between two code paths
> and confirms that the inconsistent operations are not recovered in the
> current function or the callers, so they constitute bugs.
>
> Note that, as a bug found by static analysis, it can be a false
> positive or hard to trigger. Multiple researchers have cross-reviewed
> the bug.
>
> drivers/media/platform/ti-vpe/cal-video.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/media/platform/ti-vpe/cal-video.c b/drivers/media/platform/ti-vpe/cal-video.c
> index 7799da1cc261..3e936a2ca36c 100644
> --- a/drivers/media/platform/ti-vpe/cal-video.c
> +++ b/drivers/media/platform/ti-vpe/cal-video.c
> @@ -823,6 +823,9 @@ static int cal_ctx_v4l2_init_formats(struct cal_ctx *ctx)
> /* Enumerate sub device formats and enable all matching local formats */
> ctx->active_fmt = devm_kcalloc(ctx->cal->dev, cal_num_formats,
> sizeof(*ctx->active_fmt), GFP_KERNEL);
> + if (!ctx->active_fmt)
> + return -ENOMEM;
> +
> ctx->num_active_fmt = 0;
>
> for (j = 0, i = 0; ; ++j) {
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2022-01-26 0:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 17:20 [PATCH] media: ti-vpe: cal: Fix a NULL pointer dereference in cal_ctx_v4l2_init_formats() Zhou Qingyang
2022-01-26 0:39 ` Laurent Pinchart [this message]
2022-01-27 10:47 ` Pratyush Yadav
2022-01-28 10:19 ` Greg KH
2022-01-28 10:32 ` Laurent Pinchart
2022-01-28 11:05 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfCYTfnQQx8wuoD3@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=bparrot@ti.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=zhou1615@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).