From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65493C5AC75 for ; Wed, 26 Jan 2022 01:00:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235490AbiAZBAW (ORCPT ); Tue, 25 Jan 2022 20:00:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235472AbiAZBAT (ORCPT ); Tue, 25 Jan 2022 20:00:19 -0500 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3980DC06161C for ; Tue, 25 Jan 2022 17:00:19 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id j5-20020a05600c1c0500b0034d2e956aadso3110487wms.4 for ; Tue, 25 Jan 2022 17:00:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=mCiwpH1Tj5ffm9C4sC9/lxXD1d3SX51Xb1WLfTTfu20=; b=LpRIG/VrnC6GCrp4hdyXzRJ38dQdmTrFu6iHffjBsOO6UtM32czxUv1s40/WnD4Kmm JNLB82PTekSexth1gIQi4LGs4HzATVIUw+nA7vt222vuoB0iejyMMmmoYn0FbKsA/6nK H2JSGeVM2zsrrqyCASnVH9VsYE/P1GbxvWuxKpR+ssiAHH9aB+BPvbuufNmpDvon+8b8 HeHU0UkeWkAuGJNhIAbadl+Hwi3JNK1h1YYPaexC52k6aRem0Bj60P2HkBlFdExadeCa meE+xqtoope/PM/dl8LUs3n85jbTq6RsJd0cNwzygnfK/8VZBDZqKspJU6CAW0LOqJ/O sNpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mCiwpH1Tj5ffm9C4sC9/lxXD1d3SX51Xb1WLfTTfu20=; b=DNBZtzf9+w54p16HIl0FQADz2kg4Kc4r4cL3Dw2XRl4ajAfd55lHDuhyyzGEgoFgUe zPPoOVLT3XTUTZYW8En07qGpXFofEI6ImYbp3N3uUI+aTbyGqLUkRriK8HbV09OepT1H +oN9jrYRmylIHBAzT/hT2um3GIuH8Mei1DZD48puvVWjvZUeatd80XFMjK2rvC+C7JaG 2qBUzhIFgGta1pD5KDQMct0oB72UcrdaJB/kz4wE+b5STnzAXuRSBMs1NIftiVwauOPm 5Y80RLppfNqYJLwtD1Rs0rH+spRrJ/CgBnk81xKK5GSXqAXHvR0WntVrQel1eKjoAawk rllQ== X-Gm-Message-State: AOAM533t6rgi6bgQEngOwmrdAcM+pKoiXMu5dixSMjBThPk8adsdBHB0 c8Ot6ObYDUKcbuj4cJ7WuVBUGA== X-Google-Smtp-Source: ABdhPJxTrc+Ub0Jexcef6gOzGjahcLBE2Htwq0AZVRPSV8ZVWwbeT25qz2t7gC3CpNrMSaxROuUYVw== X-Received: by 2002:a1c:a90e:: with SMTP id s14mr5116245wme.13.1643158817279; Tue, 25 Jan 2022 17:00:17 -0800 (PST) Received: from equinox (2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.a.1.e.e.d.f.d.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:dfde:e1a0::2]) by smtp.gmail.com with ESMTPSA id a14sm19528005wri.25.2022.01.25.17.00.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jan 2022 17:00:16 -0800 (PST) Date: Wed, 26 Jan 2022 01:00:15 +0000 From: Phillip Potter To: Pavel Skripkin Cc: dan.carpenter@oracle.com, Larry.Finger@lwfinger.net, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/10] staging: r8188eu: remove smaller sets of DBG_88E calls from core dir Message-ID: References: <20220124224415.831-1-phil@philpotter.co.uk> <20220124224415.831-3-phil@philpotter.co.uk> <47fcbfb5-ee59-a1ef-781d-83989e26e1aa@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47fcbfb5-ee59-a1ef-781d-83989e26e1aa@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 25, 2022 at 09:17:46PM +0300, Pavel Skripkin wrote: > Hi Phillip, > > On 1/25/22 01:44, Phillip Potter wrote: > > Remove all DBG_88E calls from the core directory, other than those in > > core/rtw_mlme_ext.c, as this contains over 100 on its own so will be > > done in a separate patch for ease of review. These calls do not conform > > to kernel coding standards and are superfluous. Also restructure where > > appropriate to remove no longer needed code left behind by removal of > > these calls. This will allow the eventual removal of the DBG_88E macro > > itself. > > > > Signed-off-by: Phillip Potter > > --- > > [code snip] > > > diff --git a/drivers/staging/r8188eu/core/rtw_ieee80211.c b/drivers/staging/r8188eu/core/rtw_ieee80211.c > > index ad87954bdeb4..62354c3194bd 100644 > > --- a/drivers/staging/r8188eu/core/rtw_ieee80211.c > > +++ b/drivers/staging/r8188eu/core/rtw_ieee80211.c > > @@ -653,13 +653,8 @@ static int rtw_ieee802_11_parse_vendor_specific(u8 *pos, uint elen, > > /* first 3 bytes in vendor specific information element are the IEEE > > * OUI of the vendor. The following byte is used a vendor specific > > * sub-type. */ > > - if (elen < 4) { > > - if (show_errors) { > > - DBG_88E("short vendor specific information element ignored (len=%lu)\n", > > - (unsigned long)elen); > > - } > > + if (elen < 4) > > return -1; > > - } > > show_errors seems unused after this change > > > oui = RTW_GET_BE24(pos); > > switch (oui) { > > @@ -674,11 +669,8 @@ static int rtw_ieee802_11_parse_vendor_specific(u8 *pos, uint elen, > > elems->wpa_ie_len = elen; > > break; > > case WME_OUI_TYPE: /* this is a Wi-Fi WME info. element */ > > - if (elen < 5) { > > - DBG_88E("short WME information element ignored (len=%lu)\n", > > - (unsigned long)elen); > > + if (elen < 5) > > return -1; > > - } > > switch (pos[4]) { > > case WME_OUI_SUBTYPE_INFORMATION_ELEMENT: > > case WME_OUI_SUBTYPE_PARAMETER_ELEMENT: > > @@ -690,8 +682,6 @@ static int rtw_ieee802_11_parse_vendor_specific(u8 *pos, uint elen, > > elems->wme_tspec_len = elen; > > break; > > default: > > - DBG_88E("unknown WME information element ignored (subtype=%d len=%lu)\n", > > - pos[4], (unsigned long)elen); > > return -1; > > } > > break; > > @@ -701,8 +691,6 @@ static int rtw_ieee802_11_parse_vendor_specific(u8 *pos, uint elen, > > elems->wps_ie_len = elen; > > break; > > default: > > - DBG_88E("Unknown Microsoft information element ignored (type=%d len=%lu)\n", > > - pos[3], (unsigned long)elen); > > return -1; > > } > > break; > > @@ -714,14 +702,10 @@ static int rtw_ieee802_11_parse_vendor_specific(u8 *pos, uint elen, > > elems->vendor_ht_cap_len = elen; > > break; > > default: > > - DBG_88E("Unknown Broadcom information element ignored (type=%d len=%lu)\n", > > - pos[3], (unsigned long)elen); > > return -1; > > } > > break; > > default: > > - DBG_88E("unknown vendor specific information element ignored (vendor OUI %02x:%02x:%02x len=%lu)\n", > > - pos[0], pos[1], pos[2], (unsigned long)elen); > > return -1; > > } > > return 0; > > @@ -752,13 +736,8 @@ enum parse_res rtw_ieee802_11_parse_elems(u8 *start, uint len, > > elen = *pos++; > > left -= 2; > > - if (elen > left) { > > - if (show_errors) { > > - DBG_88E("IEEE 802.11 element parse failed (id=%d elen=%d left=%lu)\n", > > - id, elen, (unsigned long)left); > > - } > > same here > > > + if (elen > left) > > return ParseFailed; > > - } > > switch (id) { > > case WLAN_EID_SSID: > > @@ -839,10 +818,6 @@ enum parse_res rtw_ieee802_11_parse_elems(u8 *start, uint len, > > break; > > default: > > unknown++; > > - if (!show_errors) > > - break; > > - DBG_88E("IEEE 802.11 element parse ignored unknown element (id=%d elen=%d)\n", > > - id, elen); > > break; > > and here > > > > With regards, > Pavel Skripkin Thanks, will take a further look when I fix up for v2. Regards, Phil