From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8712C433F5 for ; Thu, 27 Jan 2022 08:57:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238079AbiA0I5f (ORCPT ); Thu, 27 Jan 2022 03:57:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238063AbiA0I5e (ORCPT ); Thu, 27 Jan 2022 03:57:34 -0500 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E5C7C061714 for ; Thu, 27 Jan 2022 00:57:33 -0800 (PST) Received: by mail-wr1-x431.google.com with SMTP id a13so3364973wrh.9 for ; Thu, 27 Jan 2022 00:57:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=eOvZPOI7RXFam/ItocxZZVe1bSa9SKQ8eYJgocnt9iw=; b=CjCNS1FGFXhJiRwBqKvDeBDBoQKi7s4iefVlGkgV/JlyDZhcXKwPRHlX1sZFEtGimM sVJOCWip25O6xTsTZd+dcO5gMdbN9GoiNDYcG0PstSeWM+i9FFCsDEZxifJGWcAl4QgB cYPGzqYuizHQaPseEqCSwyDZS0wBj1foMit6V8WN0nShT5gpJKBPxLn3vo0BFdWJbyUJ h1PtYlVnVeBoqglrG8pyVweAGbbGwV6cxB9+h5UKhV87e8MxGS/gzI8FwAVDo7Fctp4X XKkt8/DXjpo4OqvrmvJDN1JWRiU3QUP3p/qwZ355ZgiYKrda/xDQgvr/yOXQSC4a+4SA m3oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eOvZPOI7RXFam/ItocxZZVe1bSa9SKQ8eYJgocnt9iw=; b=HBv6/lIRzgkh/dsuu5Jsin2ZnqOUcfCugBBivQTj6ACU8LFgVUFWI6ar68mm0bgfqv Ds8SiXUbjSvJraXMw8WgiOh6eSxH0Evk8wg9ryqqXLcMnBDcw9sKAEEA8RFkmuHSEB36 sRH/jMgm5GrGMLKFn1jBDpGxRwTmKFWfH/vC1scICqOb7WlMcaMrcp8qFVkn7ToIqcCn pWCdTnACq0c3jGuOvGdk3XfgTrlp++7sK1I9PPiwbx99kt0zri4eRsN2nSfVt6Dktcm9 bd8EkCI3OslzA4BwBWhFlfqMW8DF1STIo5utelsVEguWsjeLlA5m/qpuSFkW6Rg9bXzD I9yA== X-Gm-Message-State: AOAM531iN4SOs8oxsO2FyM+11Ub4+3thv5G8NKFcqNKodOtmtv1N3H1t 6wjVkISaDm3K484NcewAWtDyNF9tG4VReA== X-Google-Smtp-Source: ABdhPJwZvxc5A1fW5LuddhyJb0yw8xCGeU8LyE6qh01sDxOX/VKiruuawOrJ0+uN1TuPEj4AdS9LDA== X-Received: by 2002:adf:e6c9:: with SMTP id y9mr2200999wrm.389.1643273851356; Thu, 27 Jan 2022 00:57:31 -0800 (PST) Received: from equinox (2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.a.1.e.e.d.f.d.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:dfde:e1a0::2]) by smtp.gmail.com with ESMTPSA id a6sm1554842wrx.101.2022.01.27.00.57.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jan 2022 00:57:30 -0800 (PST) Date: Thu, 27 Jan 2022 08:57:29 +0000 From: Phillip Potter To: Michael Straube Cc: gregkh@linuxfoundation.org, dan.carpenter@oracle.com, Larry.Finger@lwfinger.net, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, paskripkin@gmail.com Subject: Re: [PATCH 10/10] staging: r8188eu: remove GlobalDebugLevel flag Message-ID: References: <20220124225032.860-1-phil@philpotter.co.uk> <20220124225950.784-1-phil@philpotter.co.uk> <20220124225950.784-3-phil@philpotter.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 26, 2022 at 11:33:46AM +0100, Michael Straube wrote: > On 1/24/22 23:59, Phillip Potter wrote: > > Remove hal/odm_debug.c, to get rid of the GlobalDebugLevel flag, > > and remove the two other lines that reference GlobalDebugLevel, as > > the last remaining user (DBG_88E) is now gone. Also modify Makefile > > to no longer build hal/odm_debug.c. > > > > Signed-off-by: Phillip Potter > > --- > > drivers/staging/r8188eu/Makefile | 1 - > > drivers/staging/r8188eu/hal/odm_debug.c | 6 ------ > > drivers/staging/r8188eu/include/rtw_debug.h | 2 -- > > drivers/staging/r8188eu/os_dep/os_intfs.c | 1 - > > 4 files changed, 10 deletions(-) > > delete mode 100644 drivers/staging/r8188eu/hal/odm_debug.c > > > > diff --git a/drivers/staging/r8188eu/Makefile b/drivers/staging/r8188eu/Makefile > > index a7a486cc16dd..ecd6fe5bd94c 100644 > > --- a/drivers/staging/r8188eu/Makefile > > +++ b/drivers/staging/r8188eu/Makefile > > @@ -10,7 +10,6 @@ r8188eu-y = \ > > hal/hal_intf.o \ > > hal/hal_com.o \ > > hal/odm.o \ > > - hal/odm_debug.o \ > > hal/odm_HWConfig.o \ > > hal/odm_RegConfig8188E.o \ > > hal/odm_RTL8188E.o \ > > diff --git a/drivers/staging/r8188eu/hal/odm_debug.c b/drivers/staging/r8188eu/hal/odm_debug.c > > deleted file mode 100644 > > index 7a134229fe39..000000000000 > > --- a/drivers/staging/r8188eu/hal/odm_debug.c > > +++ /dev/null > > @@ -1,6 +0,0 @@ > > -// SPDX-License-Identifier: GPL-2.0 > > -/* Copyright(c) 2007 - 2011 Realtek Corporation. */ > > - > > -#include "../include/rtw_debug.h" > > - > > -u32 GlobalDebugLevel; > > diff --git a/drivers/staging/r8188eu/include/rtw_debug.h b/drivers/staging/r8188eu/include/rtw_debug.h > > index 959fb6bd25ca..01a7d987d6cc 100644 > > --- a/drivers/staging/r8188eu/include/rtw_debug.h > > +++ b/drivers/staging/r8188eu/include/rtw_debug.h > > @@ -52,6 +52,4 @@ > > #define DRIVER_PREFIX "R8188EU: " > > -extern u32 GlobalDebugLevel; > > - > > #endif /* __RTW_DEBUG_H__ */ > > diff --git a/drivers/staging/r8188eu/os_dep/os_intfs.c b/drivers/staging/r8188eu/os_dep/os_intfs.c > > index 17249b4fb7ad..8589de487289 100644 > > --- a/drivers/staging/r8188eu/os_dep/os_intfs.c > > +++ b/drivers/staging/r8188eu/os_dep/os_intfs.c > > @@ -155,7 +155,6 @@ static uint loadparam(struct adapter *padapter) > > { > > struct registry_priv *registry_par = &padapter->registrypriv; > > - GlobalDebugLevel = rtw_debug; > > registry_par->chip_version = (u8)rtw_chip_version; > > registry_par->rfintfs = (u8)rtw_rfintfs; > > registry_par->lbkmode = (u8)rtw_lbkmode; > > Hi Phillip, > > so rtw_debug is unused now. Should we remove the 'debug' module > parameter and rtw_debug as well? > > Regards, > Michael Good point, might as well. Will add this into v2. Thanks for the suggestion. Regards, Phil