From: Greg KH <gregkh@linuxfoundation.org>
To: Zhou Qingyang <zhou1615@umn.edu>
Cc: kjlu@umn.edu, Mauro Carvalho Chehab <mchehab@kernel.org>,
Zhen Lei <thunder.leizhen@huawei.com>,
Arnd Bergmann <arnd@arndb.de>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Michael Schimek <mschimek@gmx.at>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: bttv: Fix a NULL pointer dereference in setup_window_lock()
Date: Fri, 28 Jan 2022 11:16:43 +0100 [thread overview]
Message-ID: <YfPCi3qijRdnHJFo@kroah.com> (raw)
In-Reply-To: <20220124170515.58519-1-zhou1615@umn.edu>
On Tue, Jan 25, 2022 at 01:05:13AM +0800, Zhou Qingyang wrote:
> In setup_window_lock(), the return value of videobuf_sg_alloc() is
> assigned to variable new and there is a dereference of it after
> that. the return value of videobuf_sg_alloc() could be NULL on
> failure of allocation, which could lead to a NULL pointer dereference.
>
> Fix this bug by adding a NULL check of new.
>
> This bug was found by a static analyzer.
>
> Builds with 'make allyesconfig' show no new warnings,
> and our static analyzer no longer warns about this code.
>
> Fixes: e5bd0260e7d3 ("V4L/DVB (5077): Bttv cropping support")
> Signed-off-by: Zhou Qingyang <zhou1615@umn.edu>
> ---
> The analysis employs differential checking to identify inconsistent
> security operations (e.g., checks or kfrees) between two code paths
> and confirms that the inconsistent operations are not recovered in the
> current function or the callers, so they constitute bugs.
>
> Note that, as a bug found by static analysis, it can be a false
> positive or hard to trigger. Multiple researchers have cross-reviewed
> the bug.
>
> drivers/media/pci/bt8xx/bttv-driver.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/pci/bt8xx/bttv-driver.c b/drivers/media/pci/bt8xx/bttv-driver.c
> index 8cc9bec43688..6338f98d845d 100644
> --- a/drivers/media/pci/bt8xx/bttv-driver.c
> +++ b/drivers/media/pci/bt8xx/bttv-driver.c
> @@ -2182,6 +2182,8 @@ static int setup_window_lock(struct bttv_fh *fh, struct bttv *btv,
> struct bttv_buffer *new;
>
> new = videobuf_sg_alloc(sizeof(*new));
> + if (!new)
> + return -ENOMEM;
> new->crop = btv->crop[!!fh->do_crop].rect;
> bttv_overlay_risc(btv, &fh->ov, fh->ovfmt, new);
> retval = bttv_switch_overlay(btv,fh,new);
> --
> 2.25.1
>
As stated before, umn.edu is still not allowed to contribute to the
Linux kernel. Please work with your administration to resolve this
issue.
prev parent reply other threads:[~2022-01-28 10:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 17:05 [PATCH] media: bttv: Fix a NULL pointer dereference in setup_window_lock() Zhou Qingyang
2022-01-28 10:16 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfPCi3qijRdnHJFo@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mschimek@gmx.at \
--cc=thunder.leizhen@huawei.com \
--cc=zhou1615@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).