From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Gerhard Engleder <gerhard@engleder-embedded.com>
Cc: linus.walleij@linaro.org, michal.simek@xilinx.com,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "pinctrl: zynqmp: Unify pin naming"
Date: Fri, 28 Jan 2022 16:49:38 +0200 [thread overview]
Message-ID: <YfQCgnmyMOvB0V/k@smile.fi.intel.com> (raw)
In-Reply-To: <YfQBemA3bCz0FdYS@smile.fi.intel.com>
On Fri, Jan 28, 2022 at 04:45:14PM +0200, Andy Shevchenko wrote:
> On Thu, Jan 27, 2022 at 08:46:02PM +0100, Gerhard Engleder wrote:
> > From: Gerhard Engleder <gerhard@engleder-embedded.com>
>
> Thanks for your report, my comments below.
>
> > This reverts commit 54784ff24971ed5bd3f1056edce998148709d0a7.
> >
> > This patch changes the pin names from "MIO%d" to "MIO-%d", but all dts
> > in arch/arm64/boot/dts/xilinx still use the old name. As a result my
> > ZCU104 has no output on serial terminal and is not reachable over
> > network.
>
> And question here again, is the pin names ABI or not?
> If it's an ABI, then it should be clarified in the documentation.
> Otherwise, I'm wondering how this even may break anything.
Meanwhile I apply this to my tree and send as fix PR to Linus.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-01-28 14:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 19:46 [PATCH] Revert "pinctrl: zynqmp: Unify pin naming" Gerhard Engleder
2022-01-28 14:45 ` Andy Shevchenko
2022-01-28 14:49 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfQCgnmyMOvB0V/k@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gerhard@engleder-embedded.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).