From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CE99C433F5 for ; Fri, 28 Jan 2022 17:38:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343920AbiA1Rir (ORCPT ); Fri, 28 Jan 2022 12:38:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237693AbiA1Riq (ORCPT ); Fri, 28 Jan 2022 12:38:46 -0500 Received: from gofer.mess.org (gofer.mess.org [IPv6:2a02:8011:d000:212::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D657C06173B for ; Fri, 28 Jan 2022 09:38:45 -0800 (PST) Received: by gofer.mess.org (Postfix, from userid 1000) id C7E2F10008F; Fri, 28 Jan 2022 17:38:43 +0000 (UTC) Date: Fri, 28 Jan 2022 17:38:43 +0000 From: Sean Young To: Shuah Khan Cc: Alexei Starovoitov , kernel test robot , Alexei Starovoitov , LKML , Linux Memory Management List , lkp@lists.01.org, kbuild test robot Subject: Re: [tools headers UAPI] e2bcbd7769: kernel-selftests.ir.make_fail Message-ID: References: <20220128075346.GG8421@xsang-OptiPlex-9020> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 28, 2022 at 10:27:52AM -0700, Shuah Khan wrote: > On 1/28/22 9:49 AM, Alexei Starovoitov wrote: > > On Fri, Jan 28, 2022 at 1:32 AM Sean Young wrote: > > > > > > > > ir_loopback.c: In function ‘main’: > > > > ir_loopback.c:147:20: error: ‘RC_PROTO_RCMM32’ undeclared (first use in this function); did you mean ‘RC_PROTO_RC6_MCE’? > > > > if (rc_proto == RC_PROTO_RCMM32 && > > > > ^~~~~~~~~~~~~~~ > > > > RC_PROTO_RC6_MCE > > > > > > So this commit removes the copy of lirc.h from tools/include/uapi/linux/lirc.h, > > > so now the test uses /usr/include/linux/lirc.h. It appears that this file > > > does not have RC_PROTO_RCMM32 defined on this system, which means it is a > > > kernel header from v5.1 or earlier (this was added in commit > > > 721074b03411327e7bf41555d4cc7c18f49313f7). > > > > > > It looks like this machine is redhat 8.3, which ships with kernel 4.18. > > > > > > I guess my change was far too optimistic; I had no ideal enterprise kernels > > > were so ancient. > > > > > > We should probably drop e2bcbd7769ee8f05e1b3d10848aace98973844e4. Sorry about > > > the turbulence. > > > > I'd rather avoid reverting. > > Just add ifdef or something to shut up the error on old distros. > > > > Sean, > > Let's not add release checks. > > Since RC_PROTO_RCMM32 is the only one missing, perhaps you could define > just that one in ir_loopback.c with a comment that it can be removed. > > ifndef RC_PROTO_RCMM32 --- Hi Shuah, I was thinking along the same lines, however RC_PROTO_RCMM32 is an enum value so a pre-processor #ifdef is not going to work. At the moment I haven't had any bright ideas other than doing a `#define RC_PROTO_RCMM32 26` at the top of the file. Open to suggestions. Thanks, Sean