From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87303C43217 for ; Fri, 28 Jan 2022 20:02:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351030AbiA1UCY (ORCPT ); Fri, 28 Jan 2022 15:02:24 -0500 Received: from mga04.intel.com ([192.55.52.120]:18956 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245650AbiA1UCX (ORCPT ); Fri, 28 Jan 2022 15:02:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643400143; x=1674936143; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=XDrmYnVBSiMMmYRQWtq8crV165wPH0HVJ543wkoAGpE=; b=AlanSKm6BigKPsRV7IGKgQzOwj1LCIs64KwPWSbbmb683QLSv1O1UETg dhzUYvwTBjtlMXs0E7uxERz00xOU3JJxLfK1M/SB+OX4I9jM+bAKDvkGn NbDto4B22/iDOmEkYGs892jM/cSh+g4KRUD8+RaZG37Fwd8J3Foi+G4as 59cxQOIZF68Cundh9nB2cfzQoKYPYkRIgcJ6q/fMWwBkrdFw7BKKCBo7n x68XJmNhNbnJQftrDx8aD5pv8Snd3eXcVxX3Xve1CDi8c1fBsKaGJLa0g sUJ8HpkGujsz56dUtIVOCdeNhRDgEWN01CZpAx2KvUltNMgjyouPHWvZW A==; X-IronPort-AV: E=McAfee;i="6200,9189,10241"; a="246030520" X-IronPort-AV: E=Sophos;i="5.88,324,1635231600"; d="scan'208";a="246030520" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2022 12:01:42 -0800 X-IronPort-AV: E=Sophos;i="5.88,324,1635231600"; d="scan'208";a="564300747" Received: from smile.fi.intel.com ([10.237.72.61]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2022 12:01:36 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nDXQ7-00FYoH-Jd; Fri, 28 Jan 2022 22:00:31 +0200 Date: Fri, 28 Jan 2022 22:00:31 +0200 From: Andy Shevchenko To: Wolfram Sang , Jean Delvare , Heiner Kallweit , Lee Jones , Tan Jui Nee , Bjorn Helgaas , Mika Westerberg , Hans de Goede , Kate Hsuan , Jonathan Yong , linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, platform-driver-x86@vger.kernel.org Cc: Jean Delvare , Peter Tyser , Andy Shevchenko , Linus Walleij , Mark Gross , Henning Schild Subject: Re: [PATCH v3 8/8] i2c: i801: convert to use common P2SB accessor Message-ID: References: <20211221181526.53798-1-andriy.shevchenko@linux.intel.com> <20211221181526.53798-9-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211221181526.53798-9-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 21, 2021 at 08:15:26PM +0200, Andy Shevchenko wrote: > Since we have a common P2SB accessor in tree we may use it instead of > open coded variants. > > Replace custom code by pci_p2sb_bar() call. Wolfram, does this change makes sense to you? Can you give your tag or comment? -- With Best Regards, Andy Shevchenko