From: Greg KH <gregkh@linuxfoundation.org>
To: Lyude Paul <lyude@redhat.com>
Cc: Alex Deucher <alexdeucher@gmail.com>,
Zhou Qingyang <zhou1615@umn.edu>,
Karol Herbst <kherbst@redhat.com>,
David Airlie <airlied@linux.ie>,
nouveau <nouveau@lists.freedesktop.org>,
Kangjie Lu <kjlu@umn.edu>, LKML <linux-kernel@vger.kernel.org>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [PATCH] drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl()
Date: Sat, 29 Jan 2022 09:32:27 +0100 [thread overview]
Message-ID: <YfT7m3muMAFzCooc@kroah.com> (raw)
In-Reply-To: <9457f3e139bdf3938e829e1affd01300c11c67dc.camel@redhat.com>
On Fri, Jan 28, 2022 at 02:57:36PM -0500, Lyude Paul wrote:
> On Fri, 2022-01-28 at 14:53 -0500, Alex Deucher wrote:
> > On Fri, Jan 28, 2022 at 2:20 PM Lyude Paul <lyude@redhat.com> wrote:
> > >
> > > Sigh-thank you for catching this - I had totally forgot about the umn.edu
> > > ban.
> > > I pushed this already but I will go ahead and send a revert for this
> > > patch.
> > > Will cc you on it as well.
> >
> > This seems short-sighted. If the patch is valid I see no reason to
> > not accept it. I'm not trying to downplay the mess umn got into, but
> > as long as the patch is well scrutinized and fixes a valid issue, it
> > should be applied rather than leaving potential bugs in place.
> >
>
> Yeah - I sent a revert for this, but that was mainly just to make sure I
> didn't cause problems with Linus or something like that. If it's all the same
> I'd much rather just leave this patch in, as looking at the code the fix seems
> completely valid.
You will not cause any problem at all, don't worry about this, it's not
your fault or responsibility. If you think the patch is fine, that's
great, no problems. But be extra careful here, treat these developers
as you would with any other "they are known to send bad patches so are
safe to ignore if I don't want to deal with it" group that many of us
maintainers already have to defend against.
thanks,
greg k-h
next prev parent reply other threads:[~2022-01-29 8:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 16:58 [PATCH] drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl() Zhou Qingyang
2022-01-25 19:11 ` Lyude Paul
2022-01-28 10:18 ` Greg KH
2022-01-28 19:20 ` Lyude Paul
2022-01-28 19:53 ` Alex Deucher
2022-01-28 19:57 ` Lyude Paul
2022-01-29 8:32 ` Greg KH [this message]
2022-01-28 19:57 ` Karol Herbst
2022-01-28 20:01 ` Alex Deucher
2022-01-29 8:30 ` Greg KH
2022-01-29 14:18 ` Kangjie Lu
2022-01-29 14:47 ` Greg KH
2022-01-29 15:19 ` Kangjie Lu
2022-01-29 15:54 ` Greg KH
2022-01-29 8:24 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfT7m3muMAFzCooc@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=airlied@linux.ie \
--cc=alexdeucher@gmail.com \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kherbst@redhat.com \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=nouveau@lists.freedesktop.org \
--cc=zhou1615@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).