On Mon, Jan 31, 2022 at 11:44:25AM +0800, kernel test robot wrote: > Hi "Jonathan, > > I love your patch! Perhaps something to improve: > [...] > drivers/clk/nxp/clk-lpc18xx-cgu.c: In function 'lpc18xx_pll1_recalc_rate': > drivers/clk/nxp/clk-lpc18xx-cgu.c:460:13: warning: variable 'stat' set but not used [-Wunused-but-set-variable] > 460 | u32 stat, ctrl; > | ^~~~ This is unrelated to my changes, I'll leave it up to the LPC18xx developers. > drivers/clk/nxp/clk-lpc18xx-cgu.c: In function 'lpc18xx_cgu_register_div': > >> drivers/clk/nxp/clk-lpc18xx-cgu.c:545:52: warning: passing argument 2 of 'lpc18xx_fill_parent_names' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] > 545 | lpc18xx_fill_parent_names(parents, clk->mux.table, clk->n_parents); > | ~~~~~~~~^~~~~~ I'll fix this for v2. Jonathan