From: Greg KH <gregkh@linuxfoundation.org>
To: Abdun Nihaal <abdun.nihaal@gmail.com>
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
straube.linux@gmail.com, martin@kaiser.cx,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 00/23] staging: r8188eu: remove unneeded ret variables
Date: Mon, 31 Jan 2022 14:03:09 +0100 [thread overview]
Message-ID: <YffeDdW5gPDIXR9f@kroah.com> (raw)
In-Reply-To: <cover.1643466748.git.abdun.nihaal@gmail.com>
On Sat, Jan 29, 2022 at 09:34:06PM +0530, Abdun Nihaal wrote:
> This patchset does the following to functions in ioctl_linux.c:
> - Remove unneeded return variable in some functions.
> These functions cannot be converted to void either because it is an
> iw_handler function or the function does return error code.
> - Propagate error code in rtw_p2p_get2 function
> - Convert some functions that always return 0 to return void
>
> v3 -> v4:
> - Split the changes into smaller patches to make it easier to review
> - Add a new patch to propagate error code in rtw_p2p_get2 function
Much nicer and easier to review, all now queued up, thanks!
greg k-h
prev parent reply other threads:[~2022-01-31 13:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-29 16:04 [PATCH v4 00/23] staging: r8188eu: remove unneeded ret variables Abdun Nihaal
2022-01-29 16:04 ` [PATCH v4 01/23] staging: r8188eu: remove unneeded variable in rtw_wx_get_essid Abdun Nihaal
2022-01-29 16:04 ` [PATCH v4 02/23] staging: r8188eu: remove unneeded variable in rtw_wx_get_enc Abdun Nihaal
2022-01-29 16:27 ` [PATCH v4 03/23] staging: r8188eu: remove unneeded variable in rtw_p2p_get Abdun Nihaal
2022-01-29 16:27 ` [PATCH v4 04/23] staging: r8188eu: remove unneeded variable in rtw_p2p_get_wps_configmethod Abdun Nihaal
2022-01-29 16:27 ` [PATCH v4 05/23] staging: r8188eu: remove unneeded variable in rtw_p2p_get_go_device_address Abdun Nihaal
2022-01-29 16:27 ` [PATCH v4 06/23] staging: r8188eu: remove unneeded variable in rtw_p2p_get_device_type Abdun Nihaal
2022-01-29 16:27 ` [PATCH v4 07/23] staging: r8188eu: remove unneeded variable in rtw_p2p_get_device_name Abdun Nihaal
2022-01-29 16:28 ` [PATCH v4 08/23] staging: r8188eu: remove unneeded variable in rtw_p2p_get_invitation_procedure Abdun Nihaal
2022-01-29 16:28 ` [PATCH v4 09/23] staging: r8188eu: propagate error code in rtw_p2p_get2 Abdun Nihaal
2022-01-29 16:28 ` [PATCH v4 10/23] staging: r8188eu: convert rtw_p2p_set_go_nego_ssid to return void Abdun Nihaal
2022-01-29 16:28 ` [PATCH v4 11/23] staging: r8188eu: convert rtw_p2p_setDN " Abdun Nihaal
2022-01-29 16:28 ` [PATCH v4 12/23] staging: r8188eu: convert rtw_p2p_get_status " Abdun Nihaal
2022-01-29 16:28 ` [PATCH v4 13/23] staging: r8188eu: convert rtw_p2p_get_req_cm " Abdun Nihaal
2022-01-29 16:28 ` [PATCH v4 14/23] staging: r8188eu: convert rtw_p2p_get_role " Abdun Nihaal
2022-01-29 16:28 ` [PATCH v4 15/23] staging: r8188eu: convert rtw_p2p_get_peer_ifaddr " Abdun Nihaal
2022-01-29 16:28 ` [PATCH v4 16/23] staging: r8188eu: convert rtw_p2p_get_peer_devaddr " Abdun Nihaal
2022-01-29 16:28 ` [PATCH v4 17/23] staging: r8188eu: convert rtw_p2p_get_peer_devaddr_by_invitation " Abdun Nihaal
2022-01-29 16:28 ` [PATCH v4 18/23] staging: r8188eu: convert rtw_p2p_get_groupid " Abdun Nihaal
2022-01-29 16:28 ` [PATCH v4 19/23] staging: r8188eu: convert rtw_p2p_get_op_ch " Abdun Nihaal
2022-01-29 16:28 ` [PATCH v4 20/23] staging: r8188eu: convert rtw_p2p_invite_req " Abdun Nihaal
2022-01-29 16:28 ` [PATCH v4 21/23] staging: r8188eu: convert rtw_p2p_set_persistent " Abdun Nihaal
2022-01-29 16:28 ` [PATCH v4 22/23] staging: r8188eu: convert rtw_p2p_prov_disc " Abdun Nihaal
2022-01-29 16:28 ` [PATCH v4 23/23] staging: r8188eu: convert rtw_p2p_got_wpsinfo " Abdun Nihaal
2022-01-31 13:03 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YffeDdW5gPDIXR9f@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=abdun.nihaal@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).