* [PATCH] ARM: dts: nuvoton,npcm7xx: remove bogus unit addresses from fixed-partition nodes
@ 2022-01-29 9:29 Jonathan Neuschäfer
2022-01-31 6:29 ` [PATCH] ARM: dts: nuvoton, npcm7xx: " Joel Stanley
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Neuschäfer @ 2022-01-29 9:29 UTC (permalink / raw)
To: openbmc
Cc: Jonathan Neuschäfer, Avi Fishman, Tomer Maimon, Tali Perry,
Patrick Venture, Nancy Yuen, Benjamin Fair, Rob Herring,
devicetree, linux-kernel
The unit addresses do not correspond to the nodes' reg properties,
because they don't have any.
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
arch/arm/boot/dts/nuvoton-npcm730-gbs.dts | 2 +-
arch/arm/boot/dts/nuvoton-npcm730-gsj.dts | 2 +-
arch/arm/boot/dts/nuvoton-npcm730-kudo.dts | 6 +++---
arch/arm/boot/dts/nuvoton-npcm750-evb.dts | 4 ++--
arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts | 6 +++---
5 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/arch/arm/boot/dts/nuvoton-npcm730-gbs.dts b/arch/arm/boot/dts/nuvoton-npcm730-gbs.dts
index eb6eb21cb2a44..33c8d5b3d679a 100644
--- a/arch/arm/boot/dts/nuvoton-npcm730-gbs.dts
+++ b/arch/arm/boot/dts/nuvoton-npcm730-gbs.dts
@@ -366,7 +366,7 @@ spi-nor@0 {
spi-max-frequency = <20000000>;
spi-rx-bus-width = <2>;
label = "bmc";
- partitions@80000000 {
+ partitions {
compatible = "fixed-partitions";
#address-cells = <1>;
#size-cells = <1>;
diff --git a/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts b/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
index d4ff49939a3d9..bbe18618f5c56 100644
--- a/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
+++ b/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
@@ -142,7 +142,7 @@ spi-nor@0 {
reg = <0>;
spi-rx-bus-width = <2>;
- partitions@80000000 {
+ partitions {
compatible = "fixed-partitions";
#address-cells = <1>;
#size-cells = <1>;
diff --git a/arch/arm/boot/dts/nuvoton-npcm730-kudo.dts b/arch/arm/boot/dts/nuvoton-npcm730-kudo.dts
index 82a104b2a65f1..8e3425cb8e8b9 100644
--- a/arch/arm/boot/dts/nuvoton-npcm730-kudo.dts
+++ b/arch/arm/boot/dts/nuvoton-npcm730-kudo.dts
@@ -388,7 +388,7 @@ spi-nor@0 {
spi-max-frequency = <5000000>;
spi-rx-bus-width = <2>;
label = "bmc";
- partitions@80000000 {
+ partitions {
compatible = "fixed-partitions";
#address-cells = <1>;
#size-cells = <1>;
@@ -422,7 +422,7 @@ spi-nor@1 {
reg = <1>;
spi-max-frequency = <5000000>;
spi-rx-bus-width = <2>;
- partitions@88000000 {
+ partitions {
compatible = "fixed-partitions";
#address-cells = <1>;
#size-cells = <1>;
@@ -447,7 +447,7 @@ spi-nor@0 {
reg = <0>;
spi-max-frequency = <5000000>;
spi-rx-bus-width = <2>;
- partitions@A0000000 {
+ partitions {
compatible = "fixed-partitions";
#address-cells = <1>;
#size-cells = <1>;
diff --git a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
index 0334641f88292..cf274c926711a 100644
--- a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
+++ b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
@@ -74,7 +74,7 @@ spi-nor@0 {
spi-rx-bus-width = <2>;
reg = <0>;
spi-max-frequency = <5000000>;
- partitions@80000000 {
+ partitions {
compatible = "fixed-partitions";
#address-cells = <1>;
#size-cells = <1>;
@@ -135,7 +135,7 @@ spi-nor@0 {
spi-rx-bus-width = <2>;
reg = <0>;
spi-max-frequency = <5000000>;
- partitions@A0000000 {
+ partitions {
compatible = "fixed-partitions";
#address-cells = <1>;
#size-cells = <1>;
diff --git a/arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts b/arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts
index 767e0ac0df7c5..7fe7efee28acb 100644
--- a/arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts
+++ b/arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts
@@ -107,7 +107,7 @@ spi-nor@0 {
reg = <0>;
spi-rx-bus-width = <2>;
- partitions@80000000 {
+ partitions {
compatible = "fixed-partitions";
#address-cells = <1>;
#size-cells = <1>;
@@ -146,7 +146,7 @@ spi-nor@1 {
reg = <1>;
npcm,fiu-rx-bus-width = <2>;
- partitions@88000000 {
+ partitions {
compatible = "fixed-partitions";
#address-cells = <1>;
#size-cells = <1>;
@@ -173,7 +173,7 @@ spi-nor@0 {
reg = <0>;
spi-rx-bus-width = <2>;
- partitions@A0000000 {
+ partitions {
compatible = "fixed-partitions";
#address-cells = <1>;
#size-cells = <1>;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: nuvoton, npcm7xx: remove bogus unit addresses from fixed-partition nodes
2022-01-29 9:29 [PATCH] ARM: dts: nuvoton,npcm7xx: remove bogus unit addresses from fixed-partition nodes Jonathan Neuschäfer
@ 2022-01-31 6:29 ` Joel Stanley
2022-01-31 14:30 ` Jonathan Neuschäfer
0 siblings, 1 reply; 3+ messages in thread
From: Joel Stanley @ 2022-01-31 6:29 UTC (permalink / raw)
To: Jonathan Neuschäfer
Cc: OpenBMC Maillist, devicetree, Tomer Maimon, Avi Fishman,
Patrick Venture, Tali Perry, Rob Herring,
Linux Kernel Mailing List, Benjamin Fair
On Sat, 29 Jan 2022 at 09:32, Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote:
>
> The unit addresses do not correspond to the nodes' reg properties,
> because they don't have any.
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Do you want to add a Fixes: line?
> ---
> arch/arm/boot/dts/nuvoton-npcm730-gbs.dts | 2 +-
> arch/arm/boot/dts/nuvoton-npcm730-gsj.dts | 2 +-
> arch/arm/boot/dts/nuvoton-npcm730-kudo.dts | 6 +++---
> arch/arm/boot/dts/nuvoton-npcm750-evb.dts | 4 ++--
> arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts | 6 +++---
> 5 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm/boot/dts/nuvoton-npcm730-gbs.dts b/arch/arm/boot/dts/nuvoton-npcm730-gbs.dts
> index eb6eb21cb2a44..33c8d5b3d679a 100644
> --- a/arch/arm/boot/dts/nuvoton-npcm730-gbs.dts
> +++ b/arch/arm/boot/dts/nuvoton-npcm730-gbs.dts
> @@ -366,7 +366,7 @@ spi-nor@0 {
> spi-max-frequency = <20000000>;
> spi-rx-bus-width = <2>;
> label = "bmc";
> - partitions@80000000 {
> + partitions {
> compatible = "fixed-partitions";
> #address-cells = <1>;
> #size-cells = <1>;
> diff --git a/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts b/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
> index d4ff49939a3d9..bbe18618f5c56 100644
> --- a/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
> +++ b/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
> @@ -142,7 +142,7 @@ spi-nor@0 {
> reg = <0>;
> spi-rx-bus-width = <2>;
>
> - partitions@80000000 {
> + partitions {
> compatible = "fixed-partitions";
> #address-cells = <1>;
> #size-cells = <1>;
> diff --git a/arch/arm/boot/dts/nuvoton-npcm730-kudo.dts b/arch/arm/boot/dts/nuvoton-npcm730-kudo.dts
> index 82a104b2a65f1..8e3425cb8e8b9 100644
> --- a/arch/arm/boot/dts/nuvoton-npcm730-kudo.dts
> +++ b/arch/arm/boot/dts/nuvoton-npcm730-kudo.dts
> @@ -388,7 +388,7 @@ spi-nor@0 {
> spi-max-frequency = <5000000>;
> spi-rx-bus-width = <2>;
> label = "bmc";
> - partitions@80000000 {
> + partitions {
> compatible = "fixed-partitions";
> #address-cells = <1>;
> #size-cells = <1>;
> @@ -422,7 +422,7 @@ spi-nor@1 {
> reg = <1>;
> spi-max-frequency = <5000000>;
> spi-rx-bus-width = <2>;
> - partitions@88000000 {
> + partitions {
> compatible = "fixed-partitions";
> #address-cells = <1>;
> #size-cells = <1>;
> @@ -447,7 +447,7 @@ spi-nor@0 {
> reg = <0>;
> spi-max-frequency = <5000000>;
> spi-rx-bus-width = <2>;
> - partitions@A0000000 {
> + partitions {
> compatible = "fixed-partitions";
> #address-cells = <1>;
> #size-cells = <1>;
> diff --git a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> index 0334641f88292..cf274c926711a 100644
> --- a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> +++ b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> @@ -74,7 +74,7 @@ spi-nor@0 {
> spi-rx-bus-width = <2>;
> reg = <0>;
> spi-max-frequency = <5000000>;
> - partitions@80000000 {
> + partitions {
> compatible = "fixed-partitions";
> #address-cells = <1>;
> #size-cells = <1>;
> @@ -135,7 +135,7 @@ spi-nor@0 {
> spi-rx-bus-width = <2>;
> reg = <0>;
> spi-max-frequency = <5000000>;
> - partitions@A0000000 {
> + partitions {
> compatible = "fixed-partitions";
> #address-cells = <1>;
> #size-cells = <1>;
> diff --git a/arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts b/arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts
> index 767e0ac0df7c5..7fe7efee28acb 100644
> --- a/arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts
> +++ b/arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts
> @@ -107,7 +107,7 @@ spi-nor@0 {
> reg = <0>;
> spi-rx-bus-width = <2>;
>
> - partitions@80000000 {
> + partitions {
> compatible = "fixed-partitions";
> #address-cells = <1>;
> #size-cells = <1>;
> @@ -146,7 +146,7 @@ spi-nor@1 {
> reg = <1>;
> npcm,fiu-rx-bus-width = <2>;
>
> - partitions@88000000 {
> + partitions {
> compatible = "fixed-partitions";
> #address-cells = <1>;
> #size-cells = <1>;
> @@ -173,7 +173,7 @@ spi-nor@0 {
> reg = <0>;
> spi-rx-bus-width = <2>;
>
> - partitions@A0000000 {
> + partitions {
> compatible = "fixed-partitions";
> #address-cells = <1>;
> #size-cells = <1>;
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: nuvoton, npcm7xx: remove bogus unit addresses from fixed-partition nodes
2022-01-31 6:29 ` [PATCH] ARM: dts: nuvoton, npcm7xx: " Joel Stanley
@ 2022-01-31 14:30 ` Jonathan Neuschäfer
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Neuschäfer @ 2022-01-31 14:30 UTC (permalink / raw)
To: Joel Stanley
Cc: Jonathan Neuschäfer, OpenBMC Maillist, devicetree,
Tomer Maimon, Avi Fishman, Patrick Venture, Tali Perry,
Rob Herring, Linux Kernel Mailing List, Benjamin Fair
[-- Attachment #1: Type: text/plain, Size: 6108 bytes --]
On Mon, Jan 31, 2022 at 06:29:42AM +0000, Joel Stanley wrote:
> On Sat, 29 Jan 2022 at 09:32, Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote:
> >
> > The unit addresses do not correspond to the nodes' reg properties,
> > because they don't have any.
> >
> > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
>
> Reviewed-by: Joel Stanley <joel@jms.id.au>
>
> Do you want to add a Fixes: line?
Sounds reasonable, I'll add it.
Jonathan
>
> > ---
> > arch/arm/boot/dts/nuvoton-npcm730-gbs.dts | 2 +-
> > arch/arm/boot/dts/nuvoton-npcm730-gsj.dts | 2 +-
> > arch/arm/boot/dts/nuvoton-npcm730-kudo.dts | 6 +++---
> > arch/arm/boot/dts/nuvoton-npcm750-evb.dts | 4 ++--
> > arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts | 6 +++---
> > 5 files changed, 10 insertions(+), 10 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/nuvoton-npcm730-gbs.dts b/arch/arm/boot/dts/nuvoton-npcm730-gbs.dts
> > index eb6eb21cb2a44..33c8d5b3d679a 100644
> > --- a/arch/arm/boot/dts/nuvoton-npcm730-gbs.dts
> > +++ b/arch/arm/boot/dts/nuvoton-npcm730-gbs.dts
> > @@ -366,7 +366,7 @@ spi-nor@0 {
> > spi-max-frequency = <20000000>;
> > spi-rx-bus-width = <2>;
> > label = "bmc";
> > - partitions@80000000 {
> > + partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > diff --git a/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts b/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
> > index d4ff49939a3d9..bbe18618f5c56 100644
> > --- a/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
> > +++ b/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
> > @@ -142,7 +142,7 @@ spi-nor@0 {
> > reg = <0>;
> > spi-rx-bus-width = <2>;
> >
> > - partitions@80000000 {
> > + partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > diff --git a/arch/arm/boot/dts/nuvoton-npcm730-kudo.dts b/arch/arm/boot/dts/nuvoton-npcm730-kudo.dts
> > index 82a104b2a65f1..8e3425cb8e8b9 100644
> > --- a/arch/arm/boot/dts/nuvoton-npcm730-kudo.dts
> > +++ b/arch/arm/boot/dts/nuvoton-npcm730-kudo.dts
> > @@ -388,7 +388,7 @@ spi-nor@0 {
> > spi-max-frequency = <5000000>;
> > spi-rx-bus-width = <2>;
> > label = "bmc";
> > - partitions@80000000 {
> > + partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > @@ -422,7 +422,7 @@ spi-nor@1 {
> > reg = <1>;
> > spi-max-frequency = <5000000>;
> > spi-rx-bus-width = <2>;
> > - partitions@88000000 {
> > + partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > @@ -447,7 +447,7 @@ spi-nor@0 {
> > reg = <0>;
> > spi-max-frequency = <5000000>;
> > spi-rx-bus-width = <2>;
> > - partitions@A0000000 {
> > + partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > diff --git a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> > index 0334641f88292..cf274c926711a 100644
> > --- a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> > +++ b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> > @@ -74,7 +74,7 @@ spi-nor@0 {
> > spi-rx-bus-width = <2>;
> > reg = <0>;
> > spi-max-frequency = <5000000>;
> > - partitions@80000000 {
> > + partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > @@ -135,7 +135,7 @@ spi-nor@0 {
> > spi-rx-bus-width = <2>;
> > reg = <0>;
> > spi-max-frequency = <5000000>;
> > - partitions@A0000000 {
> > + partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > diff --git a/arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts b/arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts
> > index 767e0ac0df7c5..7fe7efee28acb 100644
> > --- a/arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts
> > +++ b/arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts
> > @@ -107,7 +107,7 @@ spi-nor@0 {
> > reg = <0>;
> > spi-rx-bus-width = <2>;
> >
> > - partitions@80000000 {
> > + partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > @@ -146,7 +146,7 @@ spi-nor@1 {
> > reg = <1>;
> > npcm,fiu-rx-bus-width = <2>;
> >
> > - partitions@88000000 {
> > + partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > @@ -173,7 +173,7 @@ spi-nor@0 {
> > reg = <0>;
> > spi-rx-bus-width = <2>;
> >
> > - partitions@A0000000 {
> > + partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > --
> > 2.34.1
> >
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-31 14:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-29 9:29 [PATCH] ARM: dts: nuvoton,npcm7xx: remove bogus unit addresses from fixed-partition nodes Jonathan Neuschäfer
2022-01-31 6:29 ` [PATCH] ARM: dts: nuvoton, npcm7xx: " Joel Stanley
2022-01-31 14:30 ` Jonathan Neuschäfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).